Skip to content

GitLab

T
tangled
Commit 4e16037f authored by danakj's avatar danakj Committed by Commit Bot
Browse files
Options

Reland "Re-enable and re-baseline table_overflow_dirty_reflow_tbody.html" 

This is a reland of 072a75f6

The test was written in a flaky way, this adds a wait for the row
removal to happen before finishing the test. It's rebaselined to match
this expectation, which was previously considered a flaky failure.

Original change's description:
> Re-enable and re-baseline table_overflow_dirty_reflow_tbody.html
>
> The test has new expectations as mock scrollbars have been removed. We
> expect it's not flaky with the improvements made to the test harness
> and site isolation. If it is flaky, we will investigate.
>
> R=vmpstr@chromium.org
>
> Bug: 891427
> Change-Id: I4791036524bcae1095f26b534d4416d941178bea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232749
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776285}

Bug: 891427
Change-Id: I892ef5233b86104dad8963186939be5c6123b38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238022
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776741}
parent e6c1ca73
Hide whitespace changes
Inline Side-by-side
Showing with 24 additions and 19 deletions
third_party/blink/web_tests/TestExpectations
View file @ 4e16037f
......@@ -1380,8 +1380,6 @@ crbug.com/891427 virtual/threaded-no-composited-antialiasing/animations/timing/a
# Next 3 here: https://ci.chromium.org/buildbot/tryserver.blink/linux-blink-rel/1215
crbug.com/891427 animations/responsive/viewport-unit-transform-responsive.html [ Pass Failure Timeout Crash ]
crbug.com/891427 animations/responsive/viewport-unit-translate-responsive.html [ Pass Failure Timeout Crash ]
# Next 1 here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7-blink-rel/1504
crbug.com/891427 tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html [ Pass Failure Timeout Crash ]
# ====== OOPIF-mode failures until here ======
# ====== Form Controls Refresh (chrome://flags/#form-controls-refresh) failures from here ======
......
third_party/blink/web_tests/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html
View file @ 4e16037f
......@@ -40,42 +40,50 @@
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>testscase for table overflow handling dirty reflow due to row removal</title>
<style type="text/css">
td {padding:15px;}
td {
padding:15px;
}
table {
width:200px;
border-spacing:30px;
}
#spacer {
height:100px;
height:100px;
}
#outer {
width:50px;
height:50px;
border: solid green 1px;
width:50px;
height:50px;
border: solid green 1px;
}
#inner {
width:400px;
height:300px;
border: solid red 1px;
width:400px;
height:300px;
border: solid red 1px;
}
#target {
vertical-align:bottom;
}
caption {caption-side:right;
border:solid orange;
height:200px}
caption {
caption-side:right;
border:solid orange;
height:200px;
}
</style>
<script type="text/javascript">
if (window.testRunner)
testRunner.waitUntilDone();
function domfunc(){
var table= document.getElementById("table_body");
var row= document.getElementById("remove");
table.removeChild(row);
var table = document.getElementById("table_body");
var row = document.getElementById("remove");
table.removeChild(row);
if (window.testRunner)
testRunner.notifyDone();
}
</script>
</head>
<body onload="window.setTimeout('domfunc()',10)">
<body onload="window.setTimeout(domfunc, 0)">
<table border="1" id="t1">
<caption id="c1">
cap
......@@ -89,7 +97,6 @@ cap
</tr>
</tbody>
</table>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment