Commit 4e2673b8 authored by Yuta Kitamura's avatar Yuta Kitamura Committed by Commit Bot

Revert "views: enable some tests with mus and cleanup comments"

This reverts commit 07a159d0.

Reason for revert: caused LSan bot failure (leak).

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28776

Original change's description:
> views: enable some tests with mus and cleanup comments
> 
> tooltip_controller_unittest and window_reorder_unittest mostly just
> work with mus. There are a couple of things that need to be disabled, but
> for the most part they just work.
> 
> Also adds comment as to why some tests are not in views_mus_unittests.
> 
> BUG=615033
> TEST=this is a test only change
> 
> Change-Id: I2e77b2624557fa7e27f4f2abb0f4de86a2b3e772
> Reviewed-on: https://chromium-review.googlesource.com/1194259
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586902}

TBR=xiyuan@chromium.org,sky@chromium.org

Change-Id: I9145b351d92f2a54aca08c9f93b2a1335a3364b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 615033
Reviewed-on: https://chromium-review.googlesource.com/1195404Reviewed-by: default avatarYuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587065}
parent aa47408b
...@@ -1091,10 +1091,8 @@ source_set("views_unittests_sources") { ...@@ -1091,10 +1091,8 @@ source_set("views_unittests_sources") {
"accessibility/ax_aura_obj_cache_unittest.cc", "accessibility/ax_aura_obj_cache_unittest.cc",
"accessibility/ax_tree_source_views_unittest.cc", "accessibility/ax_tree_source_views_unittest.cc",
"controls/native/native_view_host_aura_unittest.cc", "controls/native/native_view_host_aura_unittest.cc",
"corewm/tooltip_controller_unittest.cc",
"touchui/touch_selection_menu_runner_views_unittest.cc", "touchui/touch_selection_menu_runner_views_unittest.cc",
"view_unittest_aura.cc", "view_unittest_aura.cc",
"widget/window_reorderer_unittest.cc",
] ]
public_deps += [ public_deps += [
"//ui/aura", "//ui/aura",
...@@ -1124,10 +1122,16 @@ test("views_unittests") { ...@@ -1124,10 +1122,16 @@ test("views_unittests") {
if (use_aura) { if (use_aura) {
sources += [ sources += [
# These tests are expecting a hierarchy as created by classic ash. They # These tests currently use AuraTestBase, but then try to use views
# are only useful for views_unittests, and not in views_mus_unittests. # objects. Thus, when they are run in views_mus_unittests, they test the
# local aura path instead of the remote mus path, so pull them
# out. crbug.com/710939.
#
# Some of the tests need drag-drop support. crbug.com/614037
"corewm/tooltip_controller_unittest.cc",
"touchui/touch_selection_controller_impl_unittest.cc", "touchui/touch_selection_controller_impl_unittest.cc",
"widget/native_widget_aura_unittest.cc", "widget/native_widget_aura_unittest.cc",
"widget/window_reorderer_unittest.cc",
] ]
if (is_mac) { if (is_mac) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment