Commit 4e2f1999 authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

[iOS] Fix Bookmark Open in New Window Crash

We should not dismiss the viewController when opening in a new Window.

Bug: 1119762
Change-Id: I3520dbbaaa4123f564df28e1636aa52e180dd025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365978
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800136}
parent b1c8586a
......@@ -2236,12 +2236,7 @@ std::vector<GURL> GetUrlsToOpen(const std::vector<const BookmarkNode*>& nodes) {
[actionFactory
actionToOpenInNewWindowWithURL:node->url()
activityOrigin:WindowActivityBookmarksOrigin
completion:^{
[self
dismissViewControllerAnimated:YES
completion:
nil];
}]];
completion:nil]];
}
[menuElements addObject:[actionFactory actionToCopyURL:node->url()]];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment