Commit 4e4ae4ae authored by Guido Urdaneta's avatar Guido Urdaneta Committed by Commit Bot

Re-enable original expectations for RTCPeerConnection onnegotationneede tests

Bug: 740501
Change-Id: I0a5caf723806cfdb4923150885c29508d367afff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570032
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651736}
parent 25ac5ddf
......@@ -5966,10 +5966,8 @@ crbug.com/922951 virtual/video-surface-layer/media/controls/overflow-menu-toggle
crbug.com/926170 external/wpt/webrtc/RTCIceConnectionState-candidate-pair.https.html [ Pass Timeout ]
crbug.com/926170 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCIceConnectionState-candidate-pair.https.html [ Pass Timeout ]
# TODO(guidou): Remove these expectations once crbug.com/740501 is fixed in third_party/webrtc.
crbug.com/740501 external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded.html [ Pass Failure Timeout ]
# This test is not intended to pass on Plan B.
crbug.com/740501 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded.html [ Pass Failure Timeout ]
crbug.com/740501 fast/peerconnection/RTCPeerConnection-AddRemoveStream.html [ Pass Failure Timeout ]
# Sheriff 2019-01-18
crbug.com/922970 external/wpt/css/css-transitions/CSSTransition-startTime.tentative.html [ Failure Pass ]
......
This is a testharness.js-based test.
PASS Creating first data channel should fire negotiationneeded event
PASS calling createDataChannel twice should fire negotiationneeded event once
FAIL addTransceiver() should fire negotiationneeded event Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'. 'unified-plan' will become the default behavior in the future, but it is currently experimental. To try it out, construct the RTCPeerConnection with sdpSemantics:'unified-plan' present in the RTCConfiguration argument.
FAIL Calling addTransceiver() twice should fire negotiationneeded event once Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'. 'unified-plan' will become the default behavior in the future, but it is currently experimental. To try it out, construct the RTCPeerConnection with sdpSemantics:'unified-plan' present in the RTCConfiguration argument.
FAIL Calling both addTransceiver() and createDataChannel() should fire negotiationneeded event once assert_unreached: Pending promise should never be resolved. Instead it is rejected with: InvalidStateError: Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'. 'unified-plan' will become the default behavior in the future, but it is currently experimental. To try it out, construct the RTCPeerConnection with sdpSemantics:'unified-plan' present in the RTCConfiguration argument. Reached unreachable code
PASS negotiationneeded event should not fire if signaling state is not stable
FAIL negotiationneeded event should fire only after signaling state go back to stable promise_test: Unhandled rejection with value: object "InvalidStateError: Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'. 'unified-plan' will become the default behavior in the future, but it is currently experimental. To try it out, construct the RTCPeerConnection with sdpSemantics:'unified-plan' present in the RTCConfiguration argument."
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment