Commit 4e503205 authored by zmo@chromium.org's avatar zmo@chromium.org

Add win8.1 support to GPUBotConfig

Also add some error message in case LoadCurrentConfig fails.

BUG=
TEST=gpu_unittests
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/299113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272488 0039d316-1c4b-4281-b951-d872f2087c98
parent 12a2c498
......@@ -545,7 +545,8 @@ GpuIDResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
base::HexStringToInt(base::UTF16ToASCII(device_string), &device);
*vendor_id = vendor;
*device_id = device;
return kGpuIDSuccess;
if (*vendor_id != 0 && *device_id != 0)
return kGpuIDSuccess;
}
return kGpuIDFailure;
}
......
......@@ -208,7 +208,8 @@ GpuIDResult CollectGpuID(uint32* vendor_id, uint32* device_id) {
if (CollectPCIVideoCardInfo(&gpu_info)) {
*vendor_id = gpu_info.gpu.vendor_id;
*device_id = gpu_info.gpu.device_id;
return kGpuIDSuccess;
if (*vendor_id != 0 && *device_id != 0)
return kGpuIDSuccess;
}
return kGpuIDFailure;
}
......
......@@ -37,7 +37,7 @@ GPUTestConfig::OS GetCurrentOS() {
return GPUTestConfig::kOsWinVista;
if (major_version == 6 && minor_version == 1)
return GPUTestConfig::kOsWin7;
if (major_version == 6 && minor_version == 2)
if (major_version == 6 && (minor_version == 2 || minor_version == 3))
return GPUTestConfig::kOsWin8;
#elif defined(OS_MACOSX)
int32 major_version = 0;
......@@ -237,6 +237,7 @@ bool GPUTestBotConfig::LoadCurrentConfig(const GPUInfo* gpu_info) {
result = CollectGpuID(&my_gpu_info.gpu.vendor_id,
&my_gpu_info.gpu.device_id);
if (result == kGpuIDNotSupported) {
LOG(ERROR) << "Fail to identify GPU";
DisableGPUInfoValidation();
rt = true;
} else {
......@@ -246,8 +247,10 @@ bool GPUTestBotConfig::LoadCurrentConfig(const GPUInfo* gpu_info) {
rt = SetGPUInfo(*gpu_info);
}
set_os(GetCurrentOS());
if (os() == kOsUnknown)
if (os() == kOsUnknown) {
LOG(ERROR) << "Unknown OS";
rt = false;
}
#if defined(NDEBUG)
set_build_type(kBuildTypeRelease);
#else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment