Do not lowercase paths in _ExtractImportantEnvironment (win toolchain).
This creates problems when running on a case sensitive file system. When the path of a checkout contains uppercase characters, the following command fails: $ gn gen out/win64 --args='target_os="win" target_cpu="x64"' ERROR at //build/config/win/BUILD.gn:338:27: Script returned non-zero exit code. vcvars_toolchain_data = exec_script("../../toolchain/win/setup_toolchain.py", .... src/build/toolchain/win/setup_toolchain.py", line 240, in main assert vc_bin_dir AssertionError Bug: None Change-Id: If4c792e9d04d56987a87a55e824d764a1c4e62ed Reviewed-on: https://chromium-review.googlesource.com/985835Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#547994}
Showing
Please register or sign in to comment