Commit 4e69cf65 authored by Xiaohan Wang's avatar Xiaohan Wang Committed by Commit Bot

Fix CdmHostFilePaths for single chrome dll

File chrome_child.dll is only available when CHROME_MULTIPLE_DLL_BROWSER
is defined. Check CHROME_MULTIPLE_DLL_BROWSER and fix the logic in
cdm_host_file_path.cc.

Bug: 1008039
Test: Manually build Chrome and verified the behavior.
Change-Id: I92d23b7a449ddfdfcdadc231ab0f012b7bd8b95d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825163Reviewed-by: default avatarJohn Rummell <jrummell@chromium.org>
Reviewed-by: default avatarWill Harris <wfh@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700043}
parent 561a338c
...@@ -511,6 +511,9 @@ static_library("common") { ...@@ -511,6 +511,9 @@ static_library("common") {
} }
if (enable_cdm_host_verification) { if (enable_cdm_host_verification) {
if (is_win && is_multi_dll_chrome) {
defines += [ "CHROME_MULTIPLE_DLL" ]
}
sources += [ sources += [
"media/cdm_host_file_path.cc", "media/cdm_host_file_path.cc",
"media/cdm_host_file_path.h", "media/cdm_host_file_path.h",
......
...@@ -11,11 +11,11 @@ ...@@ -11,11 +11,11 @@
#include "base/stl_util.h" #include "base/stl_util.h"
#include "build/branding_buildflags.h" #include "build/branding_buildflags.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_version.h" #include "chrome/common/chrome_version.h"
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#include "base/mac/bundle_locations.h" #include "base/mac/bundle_locations.h"
#include "chrome/common/chrome_constants.h"
#endif #endif
#if BUILDFLAG(GOOGLE_CHROME_BRANDING) #if BUILDFLAG(GOOGLE_CHROME_BRANDING)
...@@ -44,9 +44,16 @@ void AddCdmHostFilePaths( ...@@ -44,9 +44,16 @@ void AddCdmHostFilePaths(
#if defined(OS_WIN) #if defined(OS_WIN)
static const base::FilePath::CharType* const kUnversionedFiles[] = { static const base::FilePath::CharType* const kUnversionedFiles[] = {
FILE_PATH_LITERAL("chrome.exe")}; chrome::kBrowserProcessExecutableName};
static const base::FilePath::CharType* const kVersionedFiles[] = { static const base::FilePath::CharType* const kVersionedFiles[] = {
FILE_PATH_LITERAL("chrome.dll"), FILE_PATH_LITERAL("chrome_child.dll")}; #if defined(CHROME_MULTIPLE_DLL)
chrome::kBrowserResourcesDll,
chrome::kChildDll
#else
chrome::kBrowserResourcesDll
#endif // defined(CHROME_MULTIPLE_DLL)
};
// Find where chrome.exe is installed. // Find where chrome.exe is installed.
base::FilePath chrome_exe_dir; base::FilePath chrome_exe_dir;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment