Commit 4ea8bdc0 authored by Livvie Lin's avatar Livvie Lin Committed by Commit Bot

Check for existence of current blocking page before forwarding commands

This will prevent crashes in cases where the current blocking page
reference has been released. Underlying issue will be fixed in a
follow-up CL.

Bug: 1044768,1045038
Change-Id: Ieda79f321a3f933369a74e539267ead95106d6e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015669Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735648}
parent 2c12b12c
......@@ -95,8 +95,10 @@ void IOSSSLErrorTabHelper::OnBlockingPageCommand(
if (!message.GetString("command", &command)) {
DLOG(WARNING) << "JS message parameter not found: command";
} else {
blocking_page_for_currently_committed_navigation_->HandleScriptCommand(
message, url, user_is_interacting, sender_frame);
if (blocking_page_for_currently_committed_navigation_) {
blocking_page_for_currently_committed_navigation_->HandleScriptCommand(
message, url, user_is_interacting, sender_frame);
}
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment