Revert "Consolidate translation check and execution logic between...
Revert "Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu" This reverts commit 24c91f76. Reason for revert: Resulting browser process crashes Original change's description: > Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu > > Consolidated logic by having RenderViewContextMenu::ExecTranslate call > TranslateManager::InitiateManualTranslation, and RenderViewContextMenu::AppendPageItems call > TranslateManager:CanManuallyTranslate. > > Bug: 898168 > Change-Id: If91cf98626f73d0c357522f8fdca840695185bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385636 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Megan Jablonski <megjablon@chromium.org> > Commit-Queue: Anthony Cui <cuianthony@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806161} TBR=avi@chromium.org,sclittle@chromium.org,megjablon@chromium.org,cuianthony@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 898168 Change-Id: I23e202b72625365eedcd124af000c972ced3f816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409140Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#806664}
Showing
This diff is collapsed.
Please register or sign in to comment