Commit 4ee73ea1 authored by Alexander Hendrich's avatar Alexander Hendrich Committed by Commit Bot

Add missing permission warnings for enterprise.* APIs

This CL adds permission warnings for these enterprise APIs:
* enterprise.deviceAttributes
* enterprise.networkingAttributes
* enterprise.platformKeys

Bug: 1080698
Change-Id: If8444762354f940fd4d592e6808da1bd6daf21c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203056
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779286}
parent 4023b8b6
......@@ -4170,6 +4170,15 @@ are declared in tools/grit/grit_rule.gni.
<message name="IDS_EXTENSION_PROMPT_WARNING_TRANSIENT_BACKGROUND" desc="Permission string for transient background permission.">
Run in the background when requested by a cooperating native application
</message>
<message name="IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_DEVICE_ATTRIBUTES" desc="Permission string for enterprise device attributes permission.">
See device information, such as its serial number or asset ID
</message>
<message name="IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_NETWORKING_ATTRIBUTES" desc="Permission string for enterprise networking attributes permission.">
See network information, such as your IP or MAC address
</message>
<message name="IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_PLATFORMKEYS" desc="Permission string for enterprise platform keys permission.">
Perform security-related tasks for your organization, such as managing certificates and keys stored on the device
</message>
</if>
<!-- Extension/App error messages -->
......
315ab1a6aaa648d90cac72ef83fd12fb0e919d26
\ No newline at end of file
......@@ -670,6 +670,15 @@ ChromePermissionMessageRule::GetAllRules() {
{IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_HARDWARE_PLATFORM,
{APIPermission::kEnterpriseHardwarePlatform},
{}},
{IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_DEVICE_ATTRIBUTES,
{APIPermission::kEnterpriseDeviceAttributes},
{}},
{IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_NETWORKING_ATTRIBUTES,
{APIPermission::kEnterpriseNetworkingAttributes},
{}},
{IDS_EXTENSION_PROMPT_WARNING_ENTERPRISE_PLATFORMKEYS,
{APIPermission::kEnterprisePlatformKeys},
{}},
{IDS_EXTENSION_PROMPT_WARNING_LOGIN, {APIPermission::kLogin}, {}},
{IDS_EXTENSION_PROMPT_WARNING_LOGIN_SCREEN_UI,
{APIPermission::kLoginScreenUi},
......
......@@ -781,13 +781,6 @@ TEST(PermissionsTest, PermissionMessages) {
skip.insert(APIPermission::kWebView);
skip.insert(APIPermission::kWindowShape);
// TODO(https://crbug.com/1080698) Add permission messages for enterprise.*
// These permissions are restricted to extensions force-installed by policy
// and don't require a prompt, i.e. they're restricted to location 'policy'.
skip.insert(APIPermission::kEnterprisePlatformKeys);
skip.insert(APIPermission::kEnterpriseDeviceAttributes);
skip.insert(APIPermission::kEnterpriseNetworkingAttributes);
// TODO(erikkay) add a string for this permission.
skip.insert(APIPermission::kBackground);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment