Commit 4ee9127b authored by David Staessens's avatar David Staessens Committed by Commit Bot

media/gpu/test: Update import mode blacklist for new video decoder tests.

This CL adds additional devices to the import mode blacklist used by the
video_decode_accelerator(_perf)_tests. The blacklist makes sure all tests are
run in allocate mode for devices not supporting import mode. The blacklist is
expanded with buddy, guado and rikku.

These devices support import mode for h264 and VP9, in which case the Vaapi is
used. But when decoding a VP8 video V4L2 is used, and only allocate mode is
supported.

TEST=./video_decode_accelerator_tests test-25fps.vp8 on rikku

BUG=chromium:988916

Change-Id: I5e60221b42d4746816665cb87ba8a8190942c9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772902
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691061}
parent 7474d4a4
...@@ -57,9 +57,12 @@ void VideoPlayerTestEnvironment::SetUp() { ...@@ -57,9 +57,12 @@ void VideoPlayerTestEnvironment::SetUp() {
// TODO(dstaessens): Remove this check once all platforms support import mode. // TODO(dstaessens): Remove this check once all platforms support import mode.
// Some older platforms do not support importing buffers, but need to allocate // Some older platforms do not support importing buffers, but need to allocate
// buffers internally in the decoder. // buffers internally in the decoder.
// Note: buddy, guado and rikku support import mode for H.264 and VP9, but for
// VP8 they use a different video decoder (V4L2 instead of VAAPI) and don't
// support import mode.
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
constexpr const char* kImportModeBlacklist[] = {"nyan_big", "nyan_blaze", constexpr const char* kImportModeBlacklist[] = {
"nyan_kitty"}; "buddy", "guado", "nyan_big", "nyan_blaze", "nyan_kitty", "rikku"};
const std::string board = base::SysInfo::GetLsbReleaseBoard(); const std::string board = base::SysInfo::GetLsbReleaseBoard();
import_supported_ = (std::find(std::begin(kImportModeBlacklist), import_supported_ = (std::find(std::begin(kImportModeBlacklist),
std::end(kImportModeBlacklist), std::end(kImportModeBlacklist),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment