Roll src/net/third_party/quiche/src/ c7efb6778..f6cb54d6b (19 commits)

https://quiche.googlesource.com/quiche.git/+log/c7efb6778396..f6cb54d6b392

$ git log c7efb6778..f6cb54d6b --date=short --no-merges --format='%ad %ae %s'
2020-02-27 nharper Move quic_crypto_server_stream.h to quic_crypto_server_stream_base.h
2020-02-27 nharper Prepare for BORINGSSL_API_VERSION change
2020-02-27 bnc Remove logging of header name and value length for headers with too long value.
2020-02-27 nharper Delay delivering 1-RTT read key to QUIC
2020-02-27 bnc gfe-relnote: remove gfe2_reloadable_flag_quic_use_session_max_inbound_header_list_size
2020-02-27 bnc Fix CryptoTestUtilsTest.
2020-02-27 wub Internal QUICHE change
2020-02-27 wub gfe-relnote: (n/a) Record total loss detection time in QuicConnectionStats. Stats only, not protected.
2020-02-27 bnc Make DCHECK in QuicConnection::OnRetransmissionTimeout() more useful.
2020-02-27 bnc Update expected ALPN token in QuicDispatcherWriteBlockedListTest.
2020-02-27 bnc Change QBONE to uppercase in comments.
2020-02-26 dmcardle Delete QuicOptional and replace uses with QuicheOptional
2020-02-26 bnc Make QboneClientTests and QboneSessionTests run with multiple non-TLS QUIC versions.
2020-02-26 nharper Split TlsConnection::SetEncryptionSecrets in two
2020-02-26 fayang gfe-relnote: In QUIC, only do minimum validation of coalesced packets (only validate connection IDs). Protected by gfe2_reloadable_flag_quic_minimum_validation_of_coalesced_packets.
2020-02-26 bnc Make QuartcStreamTest run with every non-TLS QUIC version.
2020-02-26 fayang gfe-relnote: In QUIC, do not send WINDOW_UPDATE if connection has been disconnected. Protected by ENABLED gfe2_reloadable_flag_quic_no_window_update_if_disconnected.
2020-02-25 bnc Use QUIC_CRYPTO in :quartc_session_test, :quartc_multiplexer_test, :quartc_bidi_test, and :quartc_peer_test.
2020-02-25 bnc Make QuicSpdyStreamTest.WritingTrailersAfterFIN not rely on AllSupportedVersions order.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I2d64aa1773fda21bffcd1171b3f8d8c261241546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080820
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745735}

DEPS

@@ -306,7 +306,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling feed
   # and whatever else without interference from each other.
-  'quiche_revision': 'c7efb677839650573cad081f8cecfde76757c2cb',
+  'quiche_revision': 'f6cb54d6b392d82ee7687b106c75646c782d97ab',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling ios_webkit
   # and whatever else without interference from each other.

net/BUILD.gn

@@ -887,7 +887,6 @@ component("net") {
       "quic/platform/impl/quic_mem_slice_storage_impl.h",
       "quic/platform/impl/quic_mutex_impl.cc",
       "quic/platform/impl/quic_mutex_impl.h",
-      "quic/platform/impl/quic_optional_impl.h",
       "quic/platform/impl/quic_pcc_sender_impl.h",
       "quic/platform/impl/quic_prefetch_impl.h",
       "quic/platform/impl/quic_ptr_util_impl.h",

net/quic/platform/impl/quic_optional_impl.h

-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef NET_QUIC_PLATFORM_IMPL_QUIC_OPTIONAL_IMPL_H_
-#define NET_QUIC_PLATFORM_IMPL_QUIC_OPTIONAL_IMPL_H_
-
-#include "base/optional.h"
-
-namespace quic {
-
-template <typename T>
-using QuicOptionalImpl = base::Optional<T>;
-
-}  // namespace quic
-
-#endif  // NET_QUIC_PLATFORM_IMPL_QUIC_OPTIONAL_IMPL_H_

net/quic/quic_flags_list.h

@@ -266,30 +266,12 @@ QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_drop_small_initial_packets,
           true)
 
-// If true, QUIC will call bandwidth sampler once per ack event, instead of once
-// per acked packet.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_one_bw_sample_per_ack_event2,
-          true)
-
-// If true, QUIC will call bandwidth sampler once per ack event, instead of once
-// per acked packet.
-QUIC_FLAG(
-    bool,
-    FLAGS_quic_reloadable_flag_quic_bw_sampler_remove_packets_once_per_congestion_event2,
-    true)
-
 // In BBR, slow pacing rate if it is likely causing overshoot.
 QUIC_FLAG(
     bool,
     FLAGS_quic_reloadable_flag_quic_bbr_mitigate_overly_large_bandwidth_sample,
     true)
 
-// If true, support QUIC BBRv2-style loss based startup exit in BBRv1.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_bbr_loss_based_startup_exit,
-          true)
-
 // The default initial value of the max ack height filter's window length.
 QUIC_FLAG(int32_t, FLAGS_quic_bbr2_default_initial_ack_height_filter_window, 10)
 
@@ -367,7 +349,9 @@ QUIC_FLAG(bool,
           false)
 
 // If true, enable QUIC version h3-25.
-QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_version_draft_25, false)
+QUIC_FLAG(bool,
+          FLAGS_quic_reloadable_flag_quic_enable_version_draft_25_v2,
+          false)
 
 // If true, fix QUIC bandwidth sampler to avoid over estimating bandwidth in
 // the presence of ack aggregation.
@@ -383,3 +367,15 @@ QUIC_FLAG(
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_spdy_enable_granular_decompress_errors,
           true)
+
+// If true, only do minimum validation of coalesced packets (only validate
+// connection ID).
+QUIC_FLAG(
+    bool,
+    FLAGS_quic_reloadable_flag_quic_minimum_validation_of_coalesced_packets,
+    false)
+
+// If true, do not send WINDOW_UPDATE if connection has been disconnected.
+QUIC_FLAG(bool,
+          FLAGS_quic_reloadable_flag_quic_no_window_update_if_disconnected,
+          true)

net/third_party/quiche/BUILD.gn

@@ -410,8 +410,8 @@ source_set("quiche") {
       "src/quic/core/quic_crypto_handshaker.h",
       "src/quic/core/quic_crypto_server_handshaker.cc",
       "src/quic/core/quic_crypto_server_handshaker.h",
-      "src/quic/core/quic_crypto_server_stream.cc",
-      "src/quic/core/quic_crypto_server_stream.h",
+      "src/quic/core/quic_crypto_server_stream_base.cc",
+      "src/quic/core/quic_crypto_server_stream_base.h",
       "src/quic/core/quic_crypto_stream.cc",
       "src/quic/core/quic_crypto_stream.h",
       "src/quic/core/quic_data_reader.cc",
@@ -521,7 +521,6 @@ source_set("quiche") {
       "src/quic/platform/api/quic_mem_slice_storage.h",
       "src/quic/platform/api/quic_mutex.cc",
       "src/quic/platform/api/quic_mutex.h",
-      "src/quic/platform/api/quic_optional.h",
       "src/quic/platform/api/quic_pcc_sender.h",
       "src/quic/platform/api/quic_prefetch.h",
       "src/quic/platform/api/quic_ptr_util.h",

third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_stream_factory.h

@@ -6,7 +6,7 @@
 #define THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_ADAPTERS_P2P_QUIC_CRYPTO_STREAM_FACTORY_H_
 
 #include "net/third_party/quiche/src/quic/core/quic_crypto_client_stream.h"
-#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream.h"
+#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream_base.h"
 
 namespace blink {
 

third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_stream_factory_impl.cc

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 #include "third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_stream_factory_impl.h"
-#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream.h"
+#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream_base.h"
 
 namespace blink {
 

third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_stream_factory_impl.h

@@ -5,7 +5,7 @@
 #ifndef THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_ADAPTERS_P2P_QUIC_CRYPTO_STREAM_FACTORY_IMPL_H_
 #define THIRD_PARTY_BLINK_RENDERER_MODULES_PEERCONNECTION_ADAPTERS_P2P_QUIC_CRYPTO_STREAM_FACTORY_IMPL_H_
 
-#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream.h"
+#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream_base.h"
 #include "third_party/blink/renderer/modules/modules_export.h"
 #include "third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_stream_factory.h"
 

third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h

@@ -12,7 +12,7 @@
 #include "net/third_party/quiche/src/quic/core/crypto/quic_crypto_server_config.h"
 #include "net/third_party/quiche/src/quic/core/quic_connection.h"
 #include "net/third_party/quiche/src/quic/core/quic_crypto_client_stream.h"
-#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream.h"
+#include "net/third_party/quiche/src/quic/core/quic_crypto_server_stream_base.h"
 #include "net/third_party/quiche/src/quic/core/quic_packet_writer.h"
 #include "net/third_party/quiche/src/quic/core/quic_session.h"
 #include "net/third_party/quiche/src/quic/tools/quic_simple_crypto_server_stream_helper.h"