Commit 4efbe80e authored by ossy@webkit.org's avatar ossy@webkit.org

ORWT shouldn't generate diff files for tests without expected files

https://bugs.webkit.org/show_bug.cgi?id=57846

Reviewed by Andreas Kling.

* Scripts/old-run-webkit-tests:

git-svn-id: svn://svn.chromium.org/blink/trunk@83055 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 25acfd35
2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Andreas Kling.
ORWT shouldn't generate diff files for tests without expected files
https://bugs.webkit.org/show_bug.cgi?id=57846
* Scripts/old-run-webkit-tests:
2011-04-05 Kevin Ollivier <kevino@theolliviers.com> 2011-04-05 Kevin Ollivier <kevino@theolliviers.com>
[wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
......
...@@ -2109,13 +2109,13 @@ sub recordActualResultsAndDiff($$) ...@@ -2109,13 +2109,13 @@ sub recordActualResultsAndDiff($$)
mkpath(dirname($actualResultsPath)); mkpath(dirname($actualResultsPath));
writeToFile("$actualResultsPath", $actualResults); writeToFile("$actualResultsPath", $actualResults);
if (-f $expectedResultPath) { # We don't need diff and pretty diff for tests without expected file.
copy("$expectedResultPath", "$copiedExpectedResultsPath"); if ( !-f $expectedResultPath) {
} else { return;
open EMPTY, ">$copiedExpectedResultsPath";
close EMPTY;
} }
copy("$expectedResultPath", "$copiedExpectedResultsPath");
my $diffOuputBasePath = File::Spec->catfile($testResultsDirectory, $base); my $diffOuputBasePath = File::Spec->catfile($testResultsDirectory, $base);
my $diffOutputPath = "$diffOuputBasePath-$diffsTag.txt"; my $diffOutputPath = "$diffOuputBasePath-$diffsTag.txt";
system "diff -u \"$copiedExpectedResultsPath\" \"$actualResultsPath\" > \"$diffOutputPath\""; system "diff -u \"$copiedExpectedResultsPath\" \"$actualResultsPath\" > \"$diffOutputPath\"";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment