Commit 4efe6e11 authored by sky@chromium.org's avatar sky@chromium.org

Gets bookmark_bar_view to compile on Linux.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115872

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17098 0039d316-1c4b-4281-b951-d872f2087c98
parent 0e863517
...@@ -11,9 +11,7 @@ ...@@ -11,9 +11,7 @@
#include "app/l10n_util.h" #include "app/l10n_util.h"
#include "app/os_exchange_data.h" #include "app/os_exchange_data.h"
#include "app/resource_bundle.h" #include "app/resource_bundle.h"
#include "app/win_util.h"
#include "base/string_util.h" #include "base/string_util.h"
#include "base/base_drag_source.h"
#include "chrome/browser/bookmarks/bookmark_context_menu.h" #include "chrome/browser/bookmarks/bookmark_context_menu.h"
#include "chrome/browser/bookmarks/bookmark_utils.h" #include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/browser.h" #include "chrome/browser/browser.h"
...@@ -45,6 +43,11 @@ ...@@ -45,6 +43,11 @@
#include "views/widget/widget.h" #include "views/widget/widget.h"
#include "views/window/window.h" #include "views/window/window.h"
#if defined(OS_WIN)
#include "app/win_util.h"
#include "base/base_drag_source.h"
#endif
using views::CustomButton; using views::CustomButton;
using views::DropTargetEvent; using views::DropTargetEvent;
using views::MenuButton; using views::MenuButton;
...@@ -146,8 +149,13 @@ static std::wstring CreateToolTipForURLAndTitle(const gfx::Point& screen_loc, ...@@ -146,8 +149,13 @@ static std::wstring CreateToolTipForURLAndTitle(const gfx::Point& screen_loc,
const GURL& url, const GURL& url,
const std::wstring& title, const std::wstring& title,
const std::wstring& languages) { const std::wstring& languages) {
const gfx::Rect monitor_bounds = win_util::GetMonitorBoundsForRect( #if defined(OS_WIN)
gfx::Rect monitor_bounds = win_util::GetMonitorBoundsForRect(
gfx::Rect(screen_loc.x(), screen_loc.y(), 1, 1)); gfx::Rect(screen_loc.x(), screen_loc.y(), 1, 1));
#else
gfx::Rect monitor_bounds(0, 0, 10000, 10000);
NOTIMPLEMENTED();
#endif
gfx::Font tt_font = views::TooltipManager::GetDefaultFont(); gfx::Font tt_font = views::TooltipManager::GetDefaultFont();
std::wstring result; std::wstring result;
...@@ -272,7 +280,7 @@ class BookmarkFolderButton : public views::MenuButton { ...@@ -272,7 +280,7 @@ class BookmarkFolderButton : public views::MenuButton {
// Tracks drops on the BookmarkBarView. // Tracks drops on the BookmarkBarView.
struct BookmarkBarView::DropInfo { struct BookmarkBarView::DropInfo {
DropInfo() : drop_index(-1), is_menu_showing(false), valid(false) {} DropInfo() : valid(false), drop_index(-1), is_menu_showing(false) {}
// Whether the data is valid. // Whether the data is valid.
bool valid; bool valid;
...@@ -362,7 +370,6 @@ static const SkBitmap& GetGroupIcon() { ...@@ -362,7 +370,6 @@ static const SkBitmap& GetGroupIcon() {
BookmarkBarView::BookmarkBarView(Profile* profile, Browser* browser) BookmarkBarView::BookmarkBarView(Profile* profile, Browser* browser)
: profile_(NULL), : profile_(NULL),
browser_(browser),
page_navigator_(NULL), page_navigator_(NULL),
model_(NULL), model_(NULL),
bookmark_menu_(NULL), bookmark_menu_(NULL),
...@@ -373,6 +380,7 @@ BookmarkBarView::BookmarkBarView(Profile* profile, Browser* browser) ...@@ -373,6 +380,7 @@ BookmarkBarView::BookmarkBarView(Profile* profile, Browser* browser)
overflow_button_(NULL), overflow_button_(NULL),
instructions_(NULL), instructions_(NULL),
bookmarks_separator_view_(NULL), bookmarks_separator_view_(NULL),
browser_(browser),
throbbing_view_(NULL) { throbbing_view_(NULL) {
SetID(VIEW_ID_BOOKMARK_BAR); SetID(VIEW_ID_BOOKMARK_BAR);
Init(); Init();
...@@ -1268,6 +1276,10 @@ void BookmarkBarView::Observe(NotificationType type, ...@@ -1268,6 +1276,10 @@ void BookmarkBarView::Observe(NotificationType type,
StopThrobbing(false); StopThrobbing(false);
bubble_url_ = GURL(); bubble_url_ = GURL();
break; break;
default:
NOTREACHED();
break;
} }
} }
...@@ -1348,10 +1360,13 @@ void BookmarkBarView::StartShowFolderDropMenuTimer(BookmarkNode* node) { ...@@ -1348,10 +1360,13 @@ void BookmarkBarView::StartShowFolderDropMenuTimer(BookmarkNode* node) {
} }
DCHECK(!show_folder_drop_menu_task_); DCHECK(!show_folder_drop_menu_task_);
show_folder_drop_menu_task_ = new ShowFolderDropMenuTask(this, node); show_folder_drop_menu_task_ = new ShowFolderDropMenuTask(this, node);
#if defined(OS_WIN)
static DWORD delay = 0; static DWORD delay = 0;
if (!delay && !SystemParametersInfo(SPI_GETMENUSHOWDELAY, 0, &delay, 0)) { if (!delay && !SystemParametersInfo(SPI_GETMENUSHOWDELAY, 0, &delay, 0))
delay = kShowFolderDropMenuDelay; delay = kShowFolderDropMenuDelay;
} #else
int delay = kShowFolderDropMenuDelay;
#endif
MessageLoop::current()->PostDelayedTask(FROM_HERE, MessageLoop::current()->PostDelayedTask(FROM_HERE,
show_folder_drop_menu_task_, delay); show_folder_drop_menu_task_, delay);
} }
......
...@@ -1687,6 +1687,8 @@ ...@@ -1687,6 +1687,8 @@
['include', '^browser/dock_info_gtk.cc'], ['include', '^browser/dock_info_gtk.cc'],
['include', '^browser/dock_info.cc'], ['include', '^browser/dock_info.cc'],
['include', '^browser/dock_info.h'], ['include', '^browser/dock_info.h'],
['include', '^browser/views/bookmark_bar_view.cc'],
['include', '^browser/views/bookmark_bar_view.h'],
['include', '^browser/views/bookmark_menu_button.cc'], ['include', '^browser/views/bookmark_menu_button.cc'],
['include', '^browser/views/bookmark_menu_button.h'], ['include', '^browser/views/bookmark_menu_button.h'],
['include', '^browser/views/bookmark_menu_controller_views.cc'], ['include', '^browser/views/bookmark_menu_controller_views.cc'],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment