Commit 4f001cca authored by dpranke@chromium.org's avatar dpranke@chromium.org

2011-03-24 Dirk Pranke <dpranke@chromium.org>

        Reviewed by Adam Barth.

        fix regressions introduced in 81908 - there were a couple of
        code paths that only fired under python 2.5 that I missed.

        Also change a couple of 'python' references to sys.executable
        in order to handle runing test-webkitpy with a binary other than
        something called 'python'.

        https://bugs.webkit.org/show_bug.cgi?id=57063

        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/test/cat.py:
        * Scripts/webkitpy/test/echo.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@81918 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent feb8082a
2011-03-24 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
fix regressions introduced in 81908 - there were a couple of
code paths that only fired under python 2.5 that I missed.
Also change a couple of 'python' references to sys.executable
in order to handle runing test-webkitpy with a binary other than
something called 'python'.
https://bugs.webkit.org/show_bug.cgi?id=57063
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/test/cat.py:
* Scripts/webkitpy/test/echo.py:
2011-03-24 Brent Fulgham <bfulgham@webkit.org> 2011-03-24 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction. Unreviewed build correction.
......
...@@ -88,14 +88,14 @@ class MacPort(WebKitPort): ...@@ -88,14 +88,14 @@ class MacPort(WebKitPort):
# four threads in parallel. # four threads in parallel.
# See https://bugs.webkit.org/show_bug.cgi?id=36622 # See https://bugs.webkit.org/show_bug.cgi?id=36622
child_processes = WebKitPort.default_child_processes(self) child_processes = WebKitPort.default_child_processes(self)
if self.get_option('worker_model') == 'old-threads' and child_processes > 4: if not self._multiprocessing_is_available and child_processes > 4:
return 4 return 4
return child_processes return child_processes
def default_worker_model(self): def default_worker_model(self):
if self._multiprocessing_is_available: if self._multiprocessing_is_available:
return 'processes' return 'processes'
return 'old-threads' return 'threads'
def baseline_search_path(self): def baseline_search_path(self):
return map(self._webkit_baseline_path, self.FALLBACK_PATHS[self._version]) return map(self._webkit_baseline_path, self.FALLBACK_PATHS[self._version])
......
...@@ -73,7 +73,7 @@ class PortTestCase(unittest.TestCase): ...@@ -73,7 +73,7 @@ class PortTestCase(unittest.TestCase):
if multiprocessing: if multiprocessing:
self.assertEqual(port.default_worker_model(), 'processes') self.assertEqual(port.default_worker_model(), 'processes')
else: else:
self.assertEqual(port.default_worker_model(), 'old-threads') self.assertEqual(port.default_worker_model(), 'threads')
def test_driver_cmd_line(self): def test_driver_cmd_line(self):
port = self.make_port() port = self.make_port()
......
...@@ -30,7 +30,7 @@ from webkitpy.common.system import fileutils ...@@ -30,7 +30,7 @@ from webkitpy.common.system import fileutils
def command_arguments(*args): def command_arguments(*args):
return ['python', __file__] + list(args) return [sys.executable, __file__] + list(args)
def main(): def main():
......
...@@ -30,7 +30,7 @@ from webkitpy.common.system import fileutils ...@@ -30,7 +30,7 @@ from webkitpy.common.system import fileutils
def command_arguments(*args): def command_arguments(*args):
return ['python', __file__] + list(args) return [sys.executable, __file__] + list(args)
def main(args=None): def main(args=None):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment