Commit 4f133c58 authored by Brandon Wylie's avatar Brandon Wylie Committed by Commit Bot

Use the correct TabDelegateFactory for ReparentingTask clients

ChromeTabCreator and CustomTabActivityTabController both have their own
instances of TabDelegateFactory that should be used with
ReparentingTask. These were changed incorrectly in crrev.com/c/1980962.

Bug: 1048602
Change-Id: I1cdac903b4794fe00f5e4ba0fb8a3d8e2bbcf4b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076005Reviewed-by: default avatarYusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745324}
parent 14d7f0e1
...@@ -319,7 +319,7 @@ public class CustomTabActivityTabController ...@@ -319,7 +319,7 @@ public class CustomTabActivityTabController
mReparentingTaskProvider.get(tab).finish( mReparentingTaskProvider.get(tab).finish(
ReparentingDelegateFactory.createReparentingTaskDelegate( ReparentingDelegateFactory.createReparentingTaskDelegate(
mActivity.getCompositorViewHolder(), mActivity.getWindowAndroid(), mActivity.getCompositorViewHolder(), mActivity.getWindowAndroid(),
mActivity.getTabDelegateFactory()), mCustomTabDelegateFactory.get()),
(params == null ? null : params.getFinalizeCallback())); (params == null ? null : params.getFinalizeCallback()));
} }
......
...@@ -157,7 +157,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator { ...@@ -157,7 +157,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
ReparentingTask.from(tab).finish( ReparentingTask.from(tab).finish(
ReparentingDelegateFactory.createReparentingTaskDelegate( ReparentingDelegateFactory.createReparentingTaskDelegate(
mActivity.getCompositorViewHolder(), mActivity.getWindowAndroid(), mActivity.getCompositorViewHolder(), mActivity.getWindowAndroid(),
mActivity.getTabDelegateFactory()), createDefaultTabDelegateFactory()),
params.getFinalizeCallback()); params.getFinalizeCallback());
} else if (asyncParams != null && asyncParams.getWebContents() != null) { } else if (asyncParams != null && asyncParams.getWebContents() != null) {
openInForeground = true; openInForeground = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment