Commit 4f21d0f8 authored by jhawkins@chromium.org's avatar jhawkins@chromium.org

Crash fix: Remove a NOTREACHED that is wrong.

I removed the return in a previous cleanup which allowed us to get data
on the fact that this is indeed reached in the wild.

R=mattm
BUG=105767
TEST=none

Review URL: http://codereview.chromium.org/8741019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112718 0039d316-1c4b-4281-b951-d872f2087c98
parent 96a555f1
......@@ -445,12 +445,15 @@ void LoginDialogCallback(const GURL& request_url,
return;
}
// Tell the password manager to look for saved passwords.
TabContentsWrapper* wrapper =
TabContentsWrapper::GetCurrentWrapperForContents(parent_contents);
if (!wrapper)
NOTREACHED() << "Login dialog created for TabContents with no wrapper";
if (!wrapper) {
// Same logic as above.
handler->CancelAuth();
return;
}
// Tell the password manager to look for saved passwords.
PasswordManager* password_manager = wrapper->password_manager();
std::vector<PasswordForm> v;
MakeInputForPasswordManager(request_url, auth_info, handler, &v);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment