Revert 285867 "Revert 285832 "Disable accessible touch explorati..."

> Revert 285832 "Disable accessible touch exploration by default."
> 
> This change was to disable the feature on M37. Reverting so that
> accessible touch exploration is enabled again on trunk.
> 
> > Disable accessible touch exploration by default.
> > 
> > Touch exploration was too buggy in M37, we don't want to launch it.
> > The plan is to land this change and merge to M37, then revert it to aim for
> > a launch of touch exploration in M38.
> > 
> > BUG=396193
> > 
> > Review URL: https://codereview.chromium.org/414493004
> 
> TBR=dmazzoni@chromium.org
> 
> Review URL: https://codereview.chromium.org/419423003

TBR=dmazzoni@google.com

Review URL: https://codereview.chromium.org/419423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285871 0039d316-1c4b-4281-b951-d872f2087c98
parent f6446bea
...@@ -42,16 +42,15 @@ const char kAshDefaultWallpaperSmall[] = "ash-default-wallpaper-small"; ...@@ -42,16 +42,15 @@ const char kAshDefaultWallpaperSmall[] = "ash-default-wallpaper-small";
// WorkspaceLayoutManager. // WorkspaceLayoutManager.
const char kAshDisableLockLayoutManager[] = "ash-disable-lock-layout-manager"; const char kAshDisableLockLayoutManager[] = "ash-disable-lock-layout-manager";
// Disable the Touch Exploration Mode. Touch Exploration Mode will no longer be
// turned on automatically when spoken feedback is enabled when this flag is
// set.
const char kAshDisableTouchExplorationMode[] =
"ash-disable-touch-exploration-mode";
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
// Enables key bindings to scroll magnified screen. // Enables key bindings to scroll magnified screen.
const char kAshEnableMagnifierKeyScroller[] = const char kAshEnableMagnifierKeyScroller[] =
"ash-enable-magnifier-key-scroller"; "ash-enable-magnifier-key-scroller";
// Enable the Touch Exploration Mode, which will be turned on automatically
// when spoken feedback is enabled.
const char kAshEnableTouchExplorationMode[] =
"ash-enable-touch-exploration-mode";
#endif #endif
// Enables text filtering with the keyboard in Overview Mode. // Enables text filtering with the keyboard in Overview Mode.
......
...@@ -25,9 +25,9 @@ ASH_EXPORT extern const char kAshDefaultWallpaperIsOem[]; ...@@ -25,9 +25,9 @@ ASH_EXPORT extern const char kAshDefaultWallpaperIsOem[];
ASH_EXPORT extern const char kAshDefaultWallpaperLarge[]; ASH_EXPORT extern const char kAshDefaultWallpaperLarge[];
ASH_EXPORT extern const char kAshDefaultWallpaperSmall[]; ASH_EXPORT extern const char kAshDefaultWallpaperSmall[];
ASH_EXPORT extern const char kAshDisableLockLayoutManager[]; ASH_EXPORT extern const char kAshDisableLockLayoutManager[];
ASH_EXPORT extern const char kAshDisableTouchExplorationMode[];
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
ASH_EXPORT extern const char kAshEnableMagnifierKeyScroller[]; ASH_EXPORT extern const char kAshEnableMagnifierKeyScroller[];
ASH_EXPORT extern const char kAshEnableTouchExplorationMode[];
#endif #endif
ASH_EXPORT extern const char kAshDisableTextFilteringInOverviewMode[]; ASH_EXPORT extern const char kAshDisableTextFilteringInOverviewMode[];
ASH_EXPORT extern const char kAshEnableSoftwareMirroring[]; ASH_EXPORT extern const char kAshEnableSoftwareMirroring[];
......
...@@ -757,8 +757,8 @@ void RootWindowController::Init(RootWindowType root_window_type, ...@@ -757,8 +757,8 @@ void RootWindowController::Init(RootWindowType root_window_type,
} }
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
if (!CommandLine::ForCurrentProcess()->HasSwitch( if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAshDisableTouchExplorationMode)) { switches::kAshEnableTouchExplorationMode)) {
touch_exploration_manager_.reset(new AshTouchExplorationManager(this)); touch_exploration_manager_.reset(new AshTouchExplorationManager(this));
} }
#endif #endif
......
...@@ -5,8 +5,10 @@ ...@@ -5,8 +5,10 @@
#include "ui/chromeos/touch_exploration_controller.h" #include "ui/chromeos/touch_exploration_controller.h"
#include "ash/accessibility_delegate.h" #include "ash/accessibility_delegate.h"
#include "ash/ash_switches.h"
#include "ash/shell.h" #include "ash/shell.h"
#include "ash/test/ash_test_base.h" #include "ash/test/ash_test_base.h"
#include "base/command_line.h"
#include "base/test/simple_test_tick_clock.h" #include "base/test/simple_test_tick_clock.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser.h"
...@@ -34,6 +36,11 @@ class TouchExplorationTest : public InProcessBrowserTest { ...@@ -34,6 +36,11 @@ class TouchExplorationTest : public InProcessBrowserTest {
virtual ~TouchExplorationTest() {} virtual ~TouchExplorationTest() {}
protected: protected:
virtual void SetUpCommandLine(base::CommandLine* command_line) OVERRIDE {
base::CommandLine::ForCurrentProcess()->AppendSwitch(
ash::switches::kAshEnableTouchExplorationMode);
}
virtual void SetUpOnMainThread() OVERRIDE { virtual void SetUpOnMainThread() OVERRIDE {
// The RenderView for WebContents is created as a result of the // The RenderView for WebContents is created as a result of the
// navigation to the New Tab page which is done as part of the test // navigation to the New Tab page which is done as part of the test
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment