Run clang-tidy modernize-use-equals-{delete,default} on //skia

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: Ifb34f30c497b206cca6b0656f60b0655409771ba
Reviewed-on: https://chromium-review.googlesource.com/790030Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519948}

skia/ext/SkDiscardableMemory_chrome.cc

@@ -11,7 +11,7 @@
 #include "base/memory/discardable_memory.h"
 #include "base/memory/discardable_memory_allocator.h"
 
-SkDiscardableMemoryChrome::~SkDiscardableMemoryChrome() {}
+SkDiscardableMemoryChrome::~SkDiscardableMemoryChrome() = default;
 
 bool SkDiscardableMemoryChrome::lock() {
   return discardable_->Lock();

skia/ext/analysis_canvas.cc

@@ -340,7 +340,7 @@ AnalysisCanvas::AnalysisCanvas(int width, int height)
       draw_op_count_(0),
       rejected_op_count_(0) {}
 
-AnalysisCanvas::~AnalysisCanvas() {}
+AnalysisCanvas::~AnalysisCanvas() = default;
 
 bool AnalysisCanvas::GetColorIfSolid(SkColor* color) const {
   if (is_transparent_) {

skia/ext/benchmarking_canvas.cc

@@ -429,8 +429,7 @@ BenchmarkingCanvas::BenchmarkingCanvas(SkCanvas* canvas)
   addCanvas(canvas);
 }
 
-BenchmarkingCanvas::~BenchmarkingCanvas() {
-}
+BenchmarkingCanvas::~BenchmarkingCanvas() = default;
 
 size_t BenchmarkingCanvas::CommandCount() const {
   return op_records_.GetSize();

skia/ext/convolver.cc

@@ -261,8 +261,7 @@ ConvolutionFilter1D::ConvolutionFilter1D()
     : max_filter_(0) {
 }
 
-ConvolutionFilter1D::~ConvolutionFilter1D() {
-}
+ConvolutionFilter1D::~ConvolutionFilter1D() = default;
 
 void ConvolutionFilter1D::AddFilter(int filter_offset,
                                     const float* filter_values,

skia/ext/skia_memory_dump_provider.cc

@@ -19,9 +19,9 @@ SkiaMemoryDumpProvider* SkiaMemoryDumpProvider::GetInstance() {
       base::LeakySingletonTraits<SkiaMemoryDumpProvider>>::get();
 }
 
-SkiaMemoryDumpProvider::SkiaMemoryDumpProvider() {}
+SkiaMemoryDumpProvider::SkiaMemoryDumpProvider() = default;
 
-SkiaMemoryDumpProvider::~SkiaMemoryDumpProvider() {}
+SkiaMemoryDumpProvider::~SkiaMemoryDumpProvider() = default;
 
 bool SkiaMemoryDumpProvider::OnMemoryDump(
     const base::trace_event::MemoryDumpArgs& args,

skia/ext/skia_trace_memory_dump_impl.cc

@@ -31,7 +31,7 @@ SkiaTraceMemoryDumpImpl::SkiaTraceMemoryDumpImpl(
               ? SkTraceMemoryDump::kLight_LevelOfDetail
               : SkTraceMemoryDump::kObjectsBreakdowns_LevelOfDetail) {}
 
-SkiaTraceMemoryDumpImpl::~SkiaTraceMemoryDumpImpl() {}
+SkiaTraceMemoryDumpImpl::~SkiaTraceMemoryDumpImpl() = default;
 
 void SkiaTraceMemoryDumpImpl::dumpNumericValue(const char* dumpName,
                                                const char* valueName,

skia/public/interfaces/image_filter_struct_traits.cc

@@ -6,7 +6,7 @@
 
 namespace mojo {
 
-ImageFilterBuffer::ImageFilterBuffer() {}
+ImageFilterBuffer::ImageFilterBuffer() = default;
 
 ImageFilterBuffer::ImageFilterBuffer(const ImageFilterBuffer& other) = default;
 

skia/public/interfaces/test/struct_traits_unittest.cc

@@ -20,7 +20,7 @@ namespace {
 
 class StructTraitsTest : public testing::Test, public mojom::TraitsTestService {
  public:
-  StructTraitsTest() {}
+  StructTraitsTest() = default;
 
  protected:
   mojom::TraitsTestServicePtr GetTraitsTestProxy() {