Commit 4f76c397 authored by Jonathan Metzman's avatar Jonathan Metzman Committed by Commit Bot

[libFuzzer] Speculative fix for broken ToT bot

Don't use explicitly link against fuzzer_no_main-x86_64.lib
since it duplicates symbols that are in some of the asan runtime
libraries. This likely breaks the old instrumentation (which we dont
use) and definitely breaks compiling libFuzzer targets on Windows
without ASAN (which we don't use on CF).

It is unclear if there is a problem for Windows users of LF or if
this was just a chrome problem since Chrome doesn't link using the
compiler driver.

Bug: 927352
Change-Id: Iefb657cee55c31b8ea2546d3a1e39a5235875f9d
Reviewed-on: https://chromium-review.googlesource.com/c/1449163
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: default avatarMax Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628212}
parent 42a33030
...@@ -259,7 +259,6 @@ config("default_sanitizer_ldflags") { ...@@ -259,7 +259,6 @@ config("default_sanitizer_ldflags") {
# Incremental linking causes padding that messes up SanitizerCoverage. # Incremental linking causes padding that messes up SanitizerCoverage.
# Don't do it. # Don't do it.
ldflags = [ "/INCREMENTAL:NO" ] ldflags = [ "/INCREMENTAL:NO" ]
libs = [ "clang_rt.fuzzer_no_main-x86_64.lib" ]
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment