Commit 4f7be0c1 authored by yoichio's avatar yoichio Committed by Commit bot

Reland of load: "Request desktop site" feature should ask reposting (patchset...

Reland of load: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2593533002/ )

Reason for revert:
This is not culprit

Original issue's description:
> Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ )
>
> Reason for revert:
> Caused browser_test failure:
> https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740
> https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090
>
> Original issue's description:
> > Reload: "Request desktop site" feature should ask reposting
> >
> > Now Android Chrome does not confirm if it is expected to repost a form
> > on selecting "Request desktop site".
> >
> > This change modifies to ask it as we do in other cases.
> >
> > If a user reject reposting, the navigation switches to use desktop user
> > agent strings as usuals, but only for the next navigation and
> > following ones.
> >
> > BUG=675522
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704
> > Cr-Commit-Position: refs/heads/master@{#439727}
>
> TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=675522
>
> Committed: https://crrev.com/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d
> Cr-Commit-Position: refs/heads/master@{#439749}

TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675522

Review-Url: https://codereview.chromium.org/2587343002
Cr-Commit-Position: refs/heads/master@{#439751}
parent 368ea13e
...@@ -340,8 +340,7 @@ void NavigationControllerAndroid::SetUseDesktopUserAgent( ...@@ -340,8 +340,7 @@ void NavigationControllerAndroid::SetUseDesktopUserAgent(
if (reload_on_state_change) { if (reload_on_state_change) {
// Reloading the page will send the override down as part of the // Reloading the page will send the override down as part of the
// navigation IPC message. // navigation IPC message.
// TODO(toyoshim): Should this call use |true| for check_for_post argument? navigation_controller_->Reload(ReloadType::ORIGINAL_REQUEST_URL, true);
navigation_controller_->Reload(ReloadType::ORIGINAL_REQUEST_URL, false);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment