Commit 4fa3cd71 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Sheriff] Disable flaky SafetyTipPageInfoBubbleViewBrowserTest tests

Disable the following flaky tests on Mac:
All/SafetyTipPageInfoBubbleViewBrowserTest.TimeOpenHistogram/1,
All/SafetyTipPageInfoBubbleViewBrowserTest.WarningDismissalCausesUkmRecordingForBlocklist/1,
All/SafetyTipPageInfoBubbleViewBrowserTest.SafetyTipShownHistogram/1, and
All/SafetyTipPageInfoBubbleViewBrowserTest.LeaveSiteStillWarnsAfter/1

Note: Unfortunately, there's no good way (that I know of) to disable a
single test case on a single platform with a single test instantiation,
so this CL disables all instantations of these test cases on Mac. This
seems better than disabling all test cases for the instantation.

TBR=jdeblasio@chromium.org
NOTRY=True

Bug: 1139955
Change-Id: I749d0ec37d227c7ec74c6fbb2128d76bf5efe18f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485134Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818498}
parent a3d186d4
...@@ -626,6 +626,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -626,6 +626,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
// If the user clicks 'leave site', the warning should re-appear when the user // If the user clicks 'leave site', the warning should re-appear when the user
// re-visits the page. // re-visits the page.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_LeaveSiteStillWarnsAfter DISABLED_LeaveSiteStillWarnsAfter
#else
#define MAYBE_LeaveSiteStillWarnsAfter LeaveSiteStillWarnsAfter
#endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
LeaveSiteStillWarnsAfter) { LeaveSiteStillWarnsAfter) {
auto kNavigatedUrl = GetURL("site1.com"); auto kNavigatedUrl = GetURL("site1.com");
...@@ -848,6 +854,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -848,6 +854,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
} }
// Tests that the SafetyTipShown histogram triggers correctly. // Tests that the SafetyTipShown histogram triggers correctly.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_SafetyTipShownHistogram DISABLED_SafetyTipShownHistogram
#else
#define MAYBE_SafetyTipShownHistogram SafetyTipShownHistogram
#endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
SafetyTipShownHistogram) { SafetyTipShownHistogram) {
const char kHistogramName[] = "Security.SafetyTips.SafetyTipShown"; const char kHistogramName[] = "Security.SafetyTips.SafetyTipShown";
...@@ -1013,6 +1025,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -1013,6 +1025,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
// Tests that the histograms recording how long the Safety Tip is open are // Tests that the histograms recording how long the Safety Tip is open are
// recorded properly. // recorded properly.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_TimeOpenHistogram DISABLED_TimeOpenHistogram
#else
#define MAYBE_TimeOpenHistogram TimeOpenHistogram
#endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
TimeOpenHistogram) { TimeOpenHistogram) {
if (!IsSuspiciousSiteWarningEnabled()) { if (!IsSuspiciousSiteWarningEnabled()) {
...@@ -1257,6 +1275,14 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -1257,6 +1275,14 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
// Tests that UKM data is only recorded after the safety tip warning is // Tests that UKM data is only recorded after the safety tip warning is
// dismissed or accepted, for the blocklist heuristic. // dismissed or accepted, for the blocklist heuristic.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_WarningDismissalCausesUkmRecordingForBlocklist \
DISABLED_WarningDismissalCausesUkmRecordingForBlocklist
#else
#define MAYBE_WarningDismissalCausesUkmRecordingForBlocklist \
WarningDismissalCausesUkmRecordingForBlocklist
#endif
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
WarningDismissalCausesUkmRecordingForBlocklist) { WarningDismissalCausesUkmRecordingForBlocklist) {
// Only test when any UI is actually enabled. // Only test when any UI is actually enabled.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment