Commit 4fd3317a authored by Sebastien Marchand's avatar Sebastien Marchand Committed by Commit Bot

Fix some discrepancies in the GpuService build rule

The condition enabling WriteClangProfilingProfile for GpuService is
mismatched with the implementation. The implementation is enabled with
CLANG_PROFILING_INSIDE_SANDBOX flag while the mojo definition is enabled
with use_clang_profiling. The correct flag is
CLANG_PROFILING_INSIDE_SANDBOX.

Bug: 1071664
Change-Id: I6e23168f76f5fafddeac997f7948823387b356a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211911
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771590}
parent 279c5f1e
......@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//build/config/profiling/profiling.gni")
import("//build/config/sanitizers/sanitizers.gni")
import("//mojo/public/tools/bindings/mojom.gni")
mojom("gl") {
......@@ -36,8 +36,8 @@ mojom("gl") {
enabled_features += [ "is_not_android" ]
}
if (use_clang_profiling) {
enabled_features += [ "use_clang_profiling" ]
if (use_clang_profiling_inside_sandbox) {
enabled_features += [ "use_clang_profiling_inside_sandbox" ]
}
cpp_typemaps = [
......
......@@ -153,7 +153,7 @@ interface GpuService {
// Write out the accumulated code profiling profile to the configured file.
// The callback is invoked once the profile has been flushed to disk.
[EnableIf=use_clang_profiling]
[EnableIf=use_clang_profiling_inside_sandbox]
WriteClangProfilingProfile() => ();
Crash();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment