Commit 4fe38f16 authored by Alice Wang's avatar Alice Wang Committed by Commit Bot

[WebSignin][Metric] Remove the metric DISMISSED_OTHER

This CL removes the metric DISMISSED_OTHER recording in the web sign-in
bottom sheet as this metric is recorded too widely for example when the
user actually signed in with the bottom sheet.

We should calculate this metric by taking the difference between the
total number that bottom sheet shows up and that user has an effective
action.

Bug: 1148307
Change-Id: I4acd06fed81af86b934ec8eba0f27920c67a3287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534893Reviewed-by: default avatarBoris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827208}
parent 1bee58fd
...@@ -31,17 +31,16 @@ public class AccountPickerBottomSheetCoordinator { ...@@ -31,17 +31,16 @@ public class AccountPickerBottomSheetCoordinator {
@Override @Override
public void onSheetClosed(@StateChangeReason int reason) { public void onSheetClosed(@StateChangeReason int reason) {
super.onSheetClosed(reason); super.onSheetClosed(reason);
final @AccountConsistencyPromoAction int promoAction;
if (reason == StateChangeReason.SWIPE) { if (reason == StateChangeReason.SWIPE) {
promoAction = AccountConsistencyPromoAction.DISMISSED_SWIPE_DOWN; AccountPickerDelegate.recordAccountConsistencyPromoAction(
AccountConsistencyPromoAction.DISMISSED_SWIPE_DOWN);
} else if (reason == StateChangeReason.BACK_PRESS) { } else if (reason == StateChangeReason.BACK_PRESS) {
promoAction = AccountConsistencyPromoAction.DISMISSED_BACK; AccountPickerDelegate.recordAccountConsistencyPromoAction(
AccountConsistencyPromoAction.DISMISSED_BACK);
} else if (reason == StateChangeReason.TAP_SCRIM) { } else if (reason == StateChangeReason.TAP_SCRIM) {
promoAction = AccountConsistencyPromoAction.DISMISSED_SCRIM; AccountPickerDelegate.recordAccountConsistencyPromoAction(
} else { AccountConsistencyPromoAction.DISMISSED_SCRIM);
promoAction = AccountConsistencyPromoAction.DISMISSED_OTHER;
} }
AccountPickerDelegate.recordAccountConsistencyPromoAction(promoAction);
} }
@Override @Override
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment