Commit 4ff5fd38 authored by Yunlian Jiang's avatar Yunlian Jiang Committed by Commit Bot

Remove template instantiation in the header file.

We got some errors in link stage when using distributed thinlto
renderer_blink_platform_impl.o.thinlto.o:renderer_blink_platform_impl.cc:vtable
for content::DeviceSensorEventPump<blink::WebDeviceMotionListener>: warning:
relocation refers to discarded section
Removing the template instantiation statement fixes this issue.

BUG=820514
TEST=emerge-samus chromeos-chrome

Change-Id: I24a8221d576adac0495ff44c7d8d110aecc586fd
Reviewed-on: https://chromium-review.googlesource.com/946681Reviewed-by: default avatarTim Volodine <timvolodine@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543224}
parent a75ef696
...@@ -17,6 +17,8 @@ ...@@ -17,6 +17,8 @@
namespace content { namespace content {
template class DeviceSensorEventPump<blink::WebDeviceMotionListener>;
DeviceMotionEventPump::DeviceMotionEventPump(RenderThread* thread) DeviceMotionEventPump::DeviceMotionEventPump(RenderThread* thread)
: DeviceSensorEventPump<blink::WebDeviceMotionListener>(thread), : DeviceSensorEventPump<blink::WebDeviceMotionListener>(thread),
accelerometer_(this, device::mojom::SensorType::ACCELEROMETER), accelerometer_(this, device::mojom::SensorType::ACCELEROMETER),
......
...@@ -41,6 +41,8 @@ bool IsSignificantlyDifferent(const device::OrientationData& data1, ...@@ -41,6 +41,8 @@ bool IsSignificantlyDifferent(const device::OrientationData& data1,
namespace content { namespace content {
template class DeviceSensorEventPump<blink::WebDeviceOrientationListener>;
const double DeviceOrientationEventPump::kOrientationThreshold = 0.1; const double DeviceOrientationEventPump::kOrientationThreshold = 0.1;
DeviceOrientationEventPump::DeviceOrientationEventPump(RenderThread* thread, DeviceOrientationEventPump::DeviceOrientationEventPump(RenderThread* thread,
......
...@@ -324,10 +324,6 @@ class CONTENT_EXPORT DeviceSensorEventPump ...@@ -324,10 +324,6 @@ class CONTENT_EXPORT DeviceSensorEventPump
DISALLOW_COPY_AND_ASSIGN(DeviceSensorEventPump); DISALLOW_COPY_AND_ASSIGN(DeviceSensorEventPump);
}; };
template class DeviceSensorEventPump<blink::WebDeviceMotionListener>;
template class DeviceSensorEventPump<blink::WebDeviceOrientationListener>;
} // namespace content } // namespace content
#endif // CONTENT_RENDERER_DEVICE_SENSORS_DEVICE_SENSOR_EVENT_PUMP_H_ #endif // CONTENT_RENDERER_DEVICE_SENSORS_DEVICE_SENSOR_EVENT_PUMP_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment