Commit 5002daf4 authored by Garrett Beaty's avatar Garrett Beaty Committed by Chromium LUCI CQ

Look for whole word matches for tree closing steps.

"compile" appears as part of the name of some tests, so using it as a
regex for tree closing is overly broad. This may still catch some
unwanted failures but should narrow the false closures.

Bug: 1159548
Change-Id: Ib19a6d5aad3818fe22430cb88007cb38f70c2615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595973Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837781}
parent b3970eb7
This diff is collapsed.
...@@ -59,13 +59,13 @@ luci.notifier( ...@@ -59,13 +59,13 @@ luci.notifier(
], ],
) )
TREE_CLOSING_STEPS = [ TREE_CLOSING_STEPS_REGEXP = "\\b({})\\b".format("|".join([
"bot_update", "bot_update",
"compile", "compile",
"gclient runhooks", "gclient runhooks",
"runhooks", "runhooks",
"update", "update",
] ]))
# This results in a notifier with no recipients, so nothing will actually be # This results in a notifier with no recipients, so nothing will actually be
# notified. This still creates a "notifiable" that can be passed to the notifies # notified. This still creates a "notifiable" that can be passed to the notifies
...@@ -91,7 +91,7 @@ def tree_closer(*, name, tree_status_host, **kwargs): ...@@ -91,7 +91,7 @@ def tree_closer(*, name, tree_status_host, **kwargs):
tree_closer( tree_closer(
name = "chromium-tree-closer", name = "chromium-tree-closer",
tree_status_host = "chromium-status.appspot.com", tree_status_host = "chromium-status.appspot.com",
failed_step_regexp = TREE_CLOSING_STEPS, failed_step_regexp = TREE_CLOSING_STEPS_REGEXP,
) )
tree_closer( tree_closer(
...@@ -104,7 +104,7 @@ def tree_closure_notifier(*, name, **kwargs): ...@@ -104,7 +104,7 @@ def tree_closure_notifier(*, name, **kwargs):
luci.notifier( luci.notifier(
name = name, name = name,
on_occurrence = ["FAILURE"], on_occurrence = ["FAILURE"],
failed_step_regexp = TREE_CLOSING_STEPS, failed_step_regexp = TREE_CLOSING_STEPS_REGEXP,
**kwargs **kwargs
) )
else: else:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment