[Profiles] Add support for Ephemeral profiles policy to signin creation

This CL fixes a crash happening after creating a signed in profile when
the policy is set.
This CL also adds browser tests checking that the signin profile is
appropriately marked and unmarked ephemeral, and correctly destroyed
at startup if required.

Fixed: 1164314
Change-Id: I078fbc127d42267261b305149aff10e71ac53b59
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617926
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841973}

chrome/browser/ui/views/profiles/profile_picker_view.cc

@@ -801,8 +801,13 @@ void ProfilePickerView::FinishSignedInCreationFlowImpl(
     return;
   }
 
-  // Unmark this profile ephemeral so that it is not deleted upon next startup.
-  entry->SetIsEphemeral(false);
+  if (!signed_in_profile_being_created_->GetPrefs()->GetBoolean(
+          prefs::kForceEphemeralProfiles)) {
+    // Unmark this profile ephemeral so that it isn't deleted upon next startup.
+    // Profiles should never be made non-ephemeral if ephemeral mode is forced
+    // by policy.
+    entry->SetIsEphemeral(false);
+  }
   entry->SetLocalProfileName(name_for_signed_in_profile_);
   ProfileMetrics::LogProfileAddNewUser(
       ProfileMetrics::ADD_NEW_PROFILE_PICKER_SIGNED_IN);