Commit 5006fac8 authored by Maggie Cai's avatar Maggie Cai Committed by Commit Bot

[Sharesheet] Update the sharesheet button labels.

This CL update the sharesheet button and context menu to use the
sharesheet label.

BUG=1097623

Change-Id: I9403ad075c3e1a7899edfd26181d4a8ed4452084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404230Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806108}
parent cf039f32
...@@ -392,6 +392,10 @@ void AddStringsForZipArchiver(base::DictionaryValue* dict) { ...@@ -392,6 +392,10 @@ void AddStringsForZipArchiver(base::DictionaryValue* dict) {
SET_STRING("ZIP_ARCHIVER_TOO_MANY_OPENED", IDS_ZIP_ARCHIVER_TOO_MANY_OPENED); SET_STRING("ZIP_ARCHIVER_TOO_MANY_OPENED", IDS_ZIP_ARCHIVER_TOO_MANY_OPENED);
} }
void AddStringsForSharesheet(base::DictionaryValue* dict) {
SET_STRING("SHARESHEET_BUTTON_LABEL", IDS_SHARESHEET_TITLE_LABEL);
}
} // namespace } // namespace
std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() { std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() {
...@@ -408,6 +412,7 @@ std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() { ...@@ -408,6 +412,7 @@ std::unique_ptr<base::DictionaryValue> GetFileManagerStrings() {
AddStringsForCrUiMenuItemShortcuts(dict.get()); AddStringsForCrUiMenuItemShortcuts(dict.get());
AddStringsForFileErrors(dict.get()); AddStringsForFileErrors(dict.get());
AddStringsForZipArchiver(dict.get()); AddStringsForZipArchiver(dict.get());
AddStringsForSharesheet(dict.get());
SET_STRING("ADD_NEW_SERVICES_BUTTON_LABEL", SET_STRING("ADD_NEW_SERVICES_BUTTON_LABEL",
IDS_FILE_BROWSER_ADD_NEW_SERVICES_BUTTON_LABEL); IDS_FILE_BROWSER_ADD_NEW_SERVICES_BUTTON_LABEL);
......
...@@ -132,7 +132,7 @@ ...@@ -132,7 +132,7 @@
<command id="open-with" label="$i18n{OPEN_WITH_BUTTON_LABEL}"> <command id="open-with" label="$i18n{OPEN_WITH_BUTTON_LABEL}">
<command id="more-actions" label="$i18n{MORE_ACTIONS_BUTTON_LABEL}"> <command id="more-actions" label="$i18n{MORE_ACTIONS_BUTTON_LABEL}">
<command id="show-submenu" label="$i18n{MORE_ACTIONS_BUTTON_LABEL}"> <command id="show-submenu" label="$i18n{MORE_ACTIONS_BUTTON_LABEL}">
<command id="invoke-sharesheet" label="$i18n{MORE_ACTIONS_BUTTON_LABEL}"> <command id="invoke-sharesheet" label="$i18n{SHARESHEET_BUTTON_LABEL}">
<command id="toggle-holding-space"> <command id="toggle-holding-space">
<command id="go-to-file-location" <command id="go-to-file-location"
label="$i18n{GO_TO_FILE_LOCATION_BUTTON_LABEL}"> label="$i18n{GO_TO_FILE_LOCATION_BUTTON_LABEL}">
...@@ -376,7 +376,7 @@ ...@@ -376,7 +376,7 @@
<div class="icon"></div> <div class="icon"></div>
</button> </button>
<cr-button id="sharesheet-button" class="icon-button menu-button" tabindex="0" hidden <cr-button id="sharesheet-button" class="icon-button menu-button" tabindex="0" hidden
aria-label="$i18n{SHARE_BUTTON_TOOLTIP}" aria-label="$i18n{SHARESHEET_BUTTON_LABEL}"
visibleif="full-page" visibleif="full-page"
command="#invoke-sharesheet" command="#invoke-sharesheet"
has-tooltip> has-tooltip>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment