Commit 501980d9 authored by Torne (Richard Coles)'s avatar Torne (Richard Coles) Committed by Commit Bot

Catch Throwable in shouldInterceptRequest.

We were only catching Exception which meant that other Throwables (often
OutOfMemoryError) were still crashing in the JNI bindings instead of
generating "nice" Java stacks.

Bug: 718929
Change-Id: I6c941002d632696c736aed9ad3304223d813c94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060671
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: default avatarTobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743103}
parent 8a3f57ff
......@@ -32,7 +32,7 @@ public abstract class AwContentsBackgroundThreadClient {
isMainFrame, hasUserGesture, method, requestHeaderNames,
requestHeaderValues)),
/*raisedException=*/false);
} catch (Exception e) {
} catch (Throwable e) {
Log.e(TAG,
"Client raised exception in shouldInterceptRequest. Re-throwing on UI thread.");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment