Implement SkTraceMemoryDump::dumpStringValue()

SkTraceMemoryDump provides Skia a way to produce Chrome memory dumps.
The dumpStringValue() function had an empty implementation however.

Bug: 1043676
Change-Id: I915ccbcb21ba4462bbb6ade1e66f64df322427ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064820Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748684}

gpu/command_buffer/common/skia_utils.cc

@@ -41,6 +41,12 @@ class SkiaGpuTraceMemoryDump : public SkTraceMemoryDump {
     auto* dump = GetOrCreateAllocatorDump(dump_name);
     dump->AddScalar(value_name, units, value);
   }
+  void dumpStringValue(const char* dump_name,
+                       const char* value_name,
+                       const char* value) override {
+    auto* dump = GetOrCreateAllocatorDump(dump_name);
+    dump->AddString(value_name, "", value);
+  }
 
   void setMemoryBacking(const char* dump_name,
                         const char* backing_type,

skia/ext/skia_trace_memory_dump_impl.cc

@@ -41,6 +41,13 @@ void SkiaTraceMemoryDumpImpl::dumpNumericValue(const char* dumpName,
   dump->AddScalar(valueName, units, value);
 }
 
+void SkiaTraceMemoryDumpImpl::dumpStringValue(const char* dump_name,
+                                              const char* value_name,
+                                              const char* value) {
+  auto* dump = process_memory_dump_->GetOrCreateAllocatorDump(dump_name);
+  dump->AddString(value_name, "", value);
+}
+
 void SkiaTraceMemoryDumpImpl::setMemoryBacking(const char* dumpName,
                                                const char* backingType,
                                                const char* backingObjectId) {

skia/ext/skia_trace_memory_dump_impl.h

@@ -43,6 +43,9 @@ class SK_API SkiaTraceMemoryDumpImpl : public SkTraceMemoryDump {
                         const char* valueName,
                         const char* units,
                         uint64_t value) override;
+  void dumpStringValue(const char* dump_name,
+                       const char* value_name,
+                       const char* value) override;
   void setMemoryBacking(const char* dumpName,
                         const char* backingType,
                         const char* backingObjectId) override;