[CodeHealth] Convert c/b//extensions from base::Bind and base::Callback to Once/Repeating

Bug: 1152282
Change-Id: I9feb70e2ff921a1dc6d3c0a7b6ac41885ee9758d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595599Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837776}

chrome/browser/extensions/chrome_extension_test_notification_observer.cc

@@ -72,8 +72,9 @@ bool ChromeExtensionTestNotificationObserver::
   ScopedObserver<ExtensionActionAPI, ExtensionActionAPI::Observer> observer(
       this);
   observer.Add(ExtensionActionAPI::Get(GetBrowserContext()));
-  WaitForCondition(
-      base::Bind(&HasPageActionVisibilityReachedTarget, browser_, count), NULL);
+  WaitForCondition(base::BindRepeating(&HasPageActionVisibilityReachedTarget,
+                                       browser_, count),
+                   nullptr);
   return true;
 }
 
@@ -88,7 +89,8 @@ bool ChromeExtensionTestNotificationObserver::WaitForExtensionViewsToLoad() {
   notification_set.Add(content::NOTIFICATION_LOAD_STOP);
   notification_set.AddExtensionFrameUnregistration(manager);
   WaitForCondition(
-      base::Bind(&HaveAllExtensionRenderFrameHostsFinishedLoading, manager),
+      base::BindRepeating(&HaveAllExtensionRenderFrameHostsFinishedLoading,
+                          manager),
       &notification_set);
   return true;
 }
@@ -97,9 +99,9 @@ bool ChromeExtensionTestNotificationObserver::WaitForExtensionIdle(
     const std::string& extension_id) {
   NotificationSet notification_set;
   notification_set.Add(content::NOTIFICATION_RENDERER_PROCESS_TERMINATED);
-  WaitForCondition(
-      base::Bind(&util::IsExtensionIdle, extension_id, GetBrowserContext()),
-      &notification_set);
+  WaitForCondition(base::BindRepeating(&util::IsExtensionIdle, extension_id,
+                                       GetBrowserContext()),
+                   &notification_set);
   return true;
 }
 
@@ -107,7 +109,7 @@ bool ChromeExtensionTestNotificationObserver::WaitForExtensionNotIdle(
     const std::string& extension_id) {
   NotificationSet notification_set;
   notification_set.Add(content::NOTIFICATION_LOAD_STOP);
-  WaitForCondition(base::Bind(
+  WaitForCondition(base::BindRepeating(
                        [](const std::string& extension_id,
                           content::BrowserContext* context) -> bool {
                          return !util::IsExtensionIdle(extension_id, context);

chrome/browser/extensions/crx_installer.cc

@@ -919,11 +919,8 @@ void CrxInstaller::CompleteInstall() {
   ExtensionAssetsManager* assets_manager =
       ExtensionAssetsManager::GetInstance();
   assets_manager->InstallExtension(
-      extension(),
-      unpacked_extension_root_,
-      install_directory_,
-      profile(),
-      base::Bind(&CrxInstaller::ReloadExtensionAfterInstall, this));
+      extension(), unpacked_extension_root_, install_directory_, profile(),
+      base::BindOnce(&CrxInstaller::ReloadExtensionAfterInstall, this));
 }
 
 void CrxInstaller::ReloadExtensionAfterInstall(

chrome/browser/extensions/extension_install_prompt_unittest.cc

@@ -42,34 +42,34 @@ namespace extensions {
 namespace {
 
 void VerifyPromptIconCallback(
-    const base::Closure& quit_closure,
+    base::OnceClosure quit_closure,
     const SkBitmap& expected_bitmap,
     ExtensionInstallPromptShowParams* params,
     ExtensionInstallPrompt::DoneCallback done_callback,
     std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt) {
   EXPECT_TRUE(gfx::BitmapsAreEqual(prompt->icon().AsBitmap(), expected_bitmap));
-  quit_closure.Run();
+  std::move(quit_closure).Run();
 }
 
 void VerifyPromptPermissionsCallback(
-    const base::Closure& quit_closure,
+    base::OnceClosure quit_closure,
     size_t regular_permissions_count,
     ExtensionInstallPromptShowParams* params,
     ExtensionInstallPrompt::DoneCallback done_callback,
     std::unique_ptr<ExtensionInstallPrompt::Prompt> install_prompt) {
   ASSERT_TRUE(install_prompt.get());
   EXPECT_EQ(regular_permissions_count, install_prompt->GetPermissionCount());
-  quit_closure.Run();
+  std::move(quit_closure).Run();
 }
 
 void VerifyPromptWithholdingUICallback(
-    const base::Closure& quit_closure,
+    base::Closure quit_closure,
     const bool should_display,
     ExtensionInstallPromptShowParams* params,
     ExtensionInstallPrompt::DoneCallback done_callback,
     std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt) {
   EXPECT_EQ(should_display, prompt->ShouldDisplayWithholdingUI());
-  quit_closure.Run();
+  std::move(quit_closure).Run();
 }
 
 void SetImage(gfx::Image* image_out,

chrome/browser/extensions/extension_service_test_with_install.cc

@@ -289,7 +289,7 @@ void ExtensionServiceTestWithInstall::UpdateExtension(
   extensions::CrxInstaller* installer = nullptr;
   content::WindowedNotificationObserver observer(
       extensions::NOTIFICATION_CRX_INSTALLER_DONE,
-      base::Bind(&IsCrxInstallerDone, &installer));
+      base::BindRepeating(&IsCrxInstallerDone, &installer));
   CRXFileInfo crx_info(path, GetTestVerifierFormat());
   crx_info.extension_id = id;
   service()->UpdateExtension(crx_info, true, &installer);

chrome/browser/extensions/extension_web_ui.cc

@@ -528,8 +528,8 @@ void ExtensionWebUI::ValidateChromeURLOverrides(Profile* profile) {
       extensions::ExtensionRegistry::Get(profile)
           ->GenerateInstalledExtensionsSet();
 
-  ForEachOverrideList(profile,
-                      base::Bind(&ValidateOverridesList, all_extensions.get()));
+  ForEachOverrideList(profile, base::BindRepeating(&ValidateOverridesList,
+                                                   all_extensions.get()));
 }
 
 // static

chrome/browser/extensions/webstore_installer_browsertest.cc

@@ -75,7 +75,7 @@ class WebstoreInstallerBrowserTest
             kNonAppDomain) {}
   ~WebstoreInstallerBrowserTest() override {}
 
-  void SetDoneClosure(base::Closure done_closure) {
+  void SetDoneClosure(base::OnceClosure done_closure) {
     done_closure_ = std::move(done_closure);
   }