Commit 50522f82 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions] Enable ExtensionActionManager tests with the "action" key

Add coverage for the "action" manifest key in ExtensionActionManager
unit tests.

Bug: 893373
Change-Id: Ifa2cabc26fc53088b45aca44133fceef2252e9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614438Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660240}
parent 38d1a4ba
...@@ -29,8 +29,7 @@ class ExtensionActionManagerTest ...@@ -29,8 +29,7 @@ class ExtensionActionManagerTest
const char* key = nullptr; const char* key = nullptr;
switch (GetParam()) { switch (GetParam()) {
case ActionInfo::TYPE_ACTION: case ActionInfo::TYPE_ACTION:
// TODO(https://crbug.com/893373): Add support for this key. key = manifest_keys::kAction;
NOTREACHED();
break; break;
case ActionInfo::TYPE_PAGE: case ActionInfo::TYPE_PAGE:
key = manifest_keys::kPageAction; key = manifest_keys::kPageAction;
...@@ -139,7 +138,8 @@ TEST_P(ExtensionActionManagerTest, TestDontOverrideIfDefaultsProvided) { ...@@ -139,7 +138,8 @@ TEST_P(ExtensionActionManagerTest, TestDontOverrideIfDefaultsProvided) {
INSTANTIATE_TEST_SUITE_P(, INSTANTIATE_TEST_SUITE_P(,
ExtensionActionManagerTest, ExtensionActionManagerTest,
testing::Values(ActionInfo::TYPE_BROWSER, testing::Values(ActionInfo::TYPE_ACTION,
ActionInfo::TYPE_BROWSER,
ActionInfo::TYPE_PAGE)); ActionInfo::TYPE_PAGE));
} // namespace extensions } // namespace extensions
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment