Commit 50526241 authored by Ella Ge's avatar Ella Ge Committed by Commit Bot

remove 'floor's from WebMouseEvent constructor

This cl removes 'floor's from a WebMouseEvent constructor.
They are missed in previous changes.

We don't need these floor since we already already remove other
trunctions and use float value for WebMouseEvent coordinates.

Bug: 456625
Change-Id: Ia1439ee2323369d0272649d5e98f632cfbdcf183
Reviewed-on: https://chromium-review.googlesource.com/940440Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarNavid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539882}
parent 9ee5170b
...@@ -336,12 +336,9 @@ void MouseEventManager::FakeMouseMoveEventTimerFired(TimerBase* timer) { ...@@ -336,12 +336,9 @@ void MouseEventManager::FakeMouseMoveEventTimerFired(TimerBase* timer) {
modifiers |= WebInputEvent::kLeftButtonDown; modifiers |= WebInputEvent::kLeftButtonDown;
} }
WebMouseEvent fake_mouse_move_event( WebMouseEvent fake_mouse_move_event(
WebInputEvent::kMouseMove, WebInputEvent::kMouseMove, last_known_mouse_position_,
WebFloatPoint(last_known_mouse_position_.X(), last_known_mouse_global_position_, button, 0, modifiers,
last_known_mouse_position_.Y()), CurrentTimeTicksInSeconds());
WebFloatPoint(last_known_mouse_global_position_.X(),
last_known_mouse_global_position_.Y()),
button, 0, modifiers, CurrentTimeTicksInSeconds());
// TODO(dtapuska): Update m_lastKnowMousePosition to be viewport coordinates. // TODO(dtapuska): Update m_lastKnowMousePosition to be viewport coordinates.
fake_mouse_move_event.SetFrameScale(1); fake_mouse_move_event.SetFrameScale(1);
Vector<WebMouseEvent> coalesced_events; Vector<WebMouseEvent> coalesced_events;
......
...@@ -123,12 +123,8 @@ static bool DragTypeIsValid(DragSourceAction action) { ...@@ -123,12 +123,8 @@ static bool DragTypeIsValid(DragSourceAction action) {
static WebMouseEvent CreateMouseEvent(DragData* drag_data) { static WebMouseEvent CreateMouseEvent(DragData* drag_data) {
WebMouseEvent result( WebMouseEvent result(
WebInputEvent::kMouseMove, WebInputEvent::kMouseMove, drag_data->ClientPosition(),
WebFloatPoint(drag_data->ClientPosition().X(), drag_data->GlobalPosition(), WebPointerProperties::Button::kLeft, 0,
drag_data->ClientPosition().Y()),
WebFloatPoint(drag_data->GlobalPosition().X(),
drag_data->GlobalPosition().Y()),
WebPointerProperties::Button::kLeft, 0,
static_cast<WebInputEvent::Modifiers>(drag_data->GetModifiers()), static_cast<WebInputEvent::Modifiers>(drag_data->GetModifiers()),
CurrentTimeTicksInSeconds()); CurrentTimeTicksInSeconds());
// TODO(dtapuska): Really we should chnage DragData to store the viewport // TODO(dtapuska): Really we should chnage DragData to store the viewport
......
...@@ -39,12 +39,11 @@ class WebMouseEvent : public WebInputEvent, public WebPointerProperties { ...@@ -39,12 +39,11 @@ class WebMouseEvent : public WebInputEvent, public WebPointerProperties {
type_param, type_param,
modifiers_param, modifiers_param,
time_stamp_seconds_param), time_stamp_seconds_param),
WebPointerProperties( WebPointerProperties(id_param,
id_param, PointerType::kMouse,
PointerType::kMouse, button_param,
button_param, position,
WebFloatPoint(floor(position.x), floor(position.y)), global_position),
WebFloatPoint(floor(global_position.x), floor(global_position.y))),
click_count(click_count_param), click_count(click_count_param),
menu_source_type(menu_source_type_param) { menu_source_type(menu_source_type_param) {
DCHECK_GE(type_param, kMouseTypeFirst); DCHECK_GE(type_param, kMouseTypeFirst);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment