[Nearby] Create crbug entries for TODOs

crbug.com/1123934: Handle errors in WebUI
crbug.com/1123942: Pass attachments to WebUI
crbug.com/1123943: Pass contact name to WebUI

Bug: None
Change-Id: I5b6c1552f730733408337373f995ad05c10e9dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389204Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803885}

chrome/browser/nearby_sharing/nearby_per_session_discovery_manager.cc

@@ -30,7 +30,7 @@ base::Optional<nearby_share::mojom::TransferStatus> GetTransferStatus(
       break;
   }
 
-  // TODO(knollr): Show error if transfer_metadata.is_final_status().
+  // TODO(crbug.com/1123934): Show error if transfer_metadata.is_final_status().
 
   // Ignore all other transfer status updates.
   return base::nullopt;

chrome/browser/nearby_sharing/nearby_process_manager.cc

@@ -241,7 +241,7 @@ void NearbyProcessManager::LaunchNewProcess() {
   StopProcess(active_profile_);
 
   // Launch a new sandboxed process.
-  // TODO(knollr): Set process name to "Nearby Sharing".
+  // TODO(crbug.com/1095650): Set process name to "Nearby Sharing".
   BindSharingProcess(sharing::LaunchSharing());
 }
 

chrome/browser/nearby_sharing/sharesheet/nearby_share_action.cc

@@ -48,18 +48,14 @@ std::vector<base::FilePath> ResolveFileUrls(
 std::vector<std::unique_ptr<Attachment>> CreateAttachmentsFromIntent(
     Profile* profile,
     apps::mojom::IntentPtr intent) {
+  DCHECK(intent->file_urls);
   std::vector<std::unique_ptr<Attachment>> attachments;
-
-  // TODO(knollr): Support other attachment types.
-  if (intent->file_urls) {
-    std::vector<base::FilePath> file_paths =
-        ResolveFileUrls(profile, *intent->file_urls);
-    for (auto& file_path : file_paths) {
-      attachments.push_back(
-          std::make_unique<FileAttachment>(std::move(file_path)));
-    }
+  std::vector<base::FilePath> file_paths =
+      ResolveFileUrls(profile, *intent->file_urls);
+  for (auto& file_path : file_paths) {
+    attachments.push_back(
+        std::make_unique<FileAttachment>(std::move(file_path)));
   }
-
   return attachments;
 }
 

chrome/browser/resources/nearby_share/nearby_confirmation_page.js

@@ -153,7 +153,7 @@ Polymer({
    * @private
    */
   contactName_() {
-    // TODO(knollr): Get contact name from ShareTarget.
+    // TODO(crbug.com/1123943): Get contact name from ShareTarget.
     const contactName = null;
     if (!contactName) {
       return '';
@@ -165,7 +165,7 @@ Polymer({
   onAcceptTap_() {
     this.confirmationManager.accept().then(
         result => {
-            // TODO(knollr): Show error if !result.success
+            // TODO(crbug.com/1123934): Show error if !result.success
         });
   },
 
@@ -188,7 +188,7 @@ Polymer({
    * @private
    */
   attachmentTitle_() {
-    // TODO(knollr): Pass attachments to UI.
+    // TODO(crbug.com/1123942): Pass attachments to UI.
     return 'Unknown file';
   },
 });

chrome/browser/resources/nearby_share/nearby_discovery_page.js

@@ -123,7 +123,7 @@ Polymer({
         .startDiscovery(this.mojoEventTarget_.$.bindNewPipeAndPassRemote())
         .then(response => {
           if (!response.success) {
-            // TODO(knollr): Show error.
+            // TODO(crbug.com/1123934): Show error.
             return;
           }
         });
@@ -196,7 +196,7 @@ Polymer({
           const {result, transferUpdateListener, confirmationManager} =
               response;
           if (result !== nearbyShare.mojom.SelectShareTargetResult.kOk) {
-            // TODO(knollr): Show error.
+            // TODO(crbug.com/crbug.com/1123934): Show error.
             return;
           }
 
@@ -249,7 +249,7 @@ Polymer({
    * @private
    */
   attachmentTitle_() {
-    // TODO(knollr): Pass attachments to UI.
+    // TODO(crbug.com/1123942): Pass attachments to UI.
     return 'Unknown file';
   },
 });