Commit 50643400 authored by rockot@chromium.org's avatar rockot@chromium.org

Remove unintended options_page support from platform apps.

Platform apps do not use an Options page. This change makes OptionsPageHandler
a no-op when parsing a platform app manifest.

BUG=229584

Review URL: https://chromiumcodereview.appspot.com/14130005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194801 0039d316-1c4b-4281-b951-d872f2087c98
parent e3eb0c41
...@@ -237,7 +237,7 @@ ...@@ -237,7 +237,7 @@
"options_page": { "options_page": {
"channel": "stable", "channel": "stable",
"extension_types": [ "extension_types": [
"extension", "packaged_app", "hosted_app", "platform_app" "extension", "packaged_app", "hosted_app"
] ]
}, },
"oauth2": { "oauth2": {
......
...@@ -32,6 +32,9 @@ TEST_F(OptionsPageManifestTest, OptionsPageInApps) { ...@@ -32,6 +32,9 @@ TEST_F(OptionsPageManifestTest, OptionsPageInApps) {
extensions::ManifestURL:: extensions::ManifestURL::
GetOptionsPage(extension).ExtractFileName().c_str()); GetOptionsPage(extension).ExtractFileName().c_str());
extension = LoadAndExpectSuccess("platform_app_with_options_page.json");
EXPECT_TRUE(extensions::ManifestURL::GetOptionsPage(extension).is_empty());
Testcase testcases[] = { Testcase testcases[] = {
// Forbid options page with relative URL in hosted apps. // Forbid options page with relative URL in hosted apps.
Testcase("hosted_app_relative_options.json", Testcase("hosted_app_relative_options.json",
......
{
"name": "test",
"description": "I specify an options_page but it should be ignored.",
"version": "1",
"app": {
"background": {
"scripts": ["background.js"]
}
},
"options_page": "options.html"
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment