Commit 507178b4 authored by Dylan Cutler's avatar Dylan Cutler Committed by Commit Bot

Fix naming style of GetUkmParameters().

Before this change it was ukm_parameters(), which is against Blink
naming convention.

Also have the functions return a const ref.

Bug: None
Change-Id: Ie527e69712be37ac5b362d462acf9b2e376e7a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366115
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800813}
parent d72ca623
......@@ -108,7 +108,9 @@ class CORE_EXPORT CanvasRenderingContextHost : public CanvasResourceHost,
// blink::CanvasImageSource
bool IsOffscreenCanvas() const override;
base::Optional<UkmParameters> ukm_parameters() { return ukm_params_; }
const base::Optional<UkmParameters>& GetUkmParameters() {
return ukm_params_;
}
protected:
~CanvasRenderingContextHost() override {}
......
......@@ -3285,7 +3285,7 @@ void WebGLRenderingContextBase::RecordIdentifiableGLParameterDigest(
IdentifiableToken value) {
if (!IsUserInIdentifiabilityStudy() || !IsIdentifiableGLParam(pname))
return;
if (base::Optional<UkmParameters> ukm_params = ukm_parameters()) {
if (const auto& ukm_params = GetUkmParameters()) {
blink::IdentifiabilityMetricBuilder(ukm_params->source_id)
.Set(blink::IdentifiableSurface::FromTypeAndInput(
blink::IdentifiableSurface::Type::kWebGLParameter, pname),
......@@ -4583,8 +4583,7 @@ void WebGLRenderingContextBase::readPixels(
GLenum type,
MaybeShared<DOMArrayBufferView> pixels) {
if (IsUserInIdentifiabilityStudy()) {
base::Optional<UkmParameters> ukm_params = ukm_parameters();
if (ukm_params) {
if (const auto& ukm_params = GetUkmParameters()) {
blink::IdentifiabilityMetricBuilder(ukm_params->source_id)
.Set(blink::IdentifiableSurface::FromTypeAndInput(
blink::IdentifiableSurface::Type::kCanvasReadback,
......
......@@ -140,8 +140,8 @@ class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext,
return static_cast<HTMLCanvasElement*>(Host());
}
base::Optional<UkmParameters> ukm_parameters() const {
return Host()->ukm_parameters();
const base::Optional<UkmParameters>& GetUkmParameters() const {
return Host()->GetUkmParameters();
}
virtual String ContextName() const = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment