Skip to content

GitLab

T
tangled
Commit 5080522a authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot
Browse files
Options

[unified-heap] Remove wrong collections test 

Removes a test that was checking that a JS wrapper was collected when
doing a V8 GC. This relies on the fact that wrapper tracing does not
see the back references in LiveNodeList::owner_.

No-try: true
Bug: 843903
Change-Id: I0586ba63f15d686a6e33c152d9eb9a8f08247cd5
Reviewed-on: https://chromium-review.googlesource.com/1243066Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593979}
parent 51865f3e
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 36 deletions
third_party/WebKit/LayoutTests/fast/dom/html-options-collection-lifetime-expected.txt deleted 100644 → 0
View file @ 51865f3e
Tests that HTMLOptionsCollection does not keep its owner node alive.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS observeSelect.wasCollected is true
PASS observeOption.wasCollected is true
PASS observeOptions.wasCollected is false
PASS successfullyParsed is true
TEST COMPLETE
third_party/WebKit/LayoutTests/fast/dom/html-options-collection-lifetime.html deleted 100644 → 0
View file @ 51865f3e
<!DOCTYPE html>
<script src="../../resources/js-test.js"></script>
<body>
<script>
description('Tests that HTMLOptionsCollection does not keep its owner node alive.');
var select = document.createElement("select");
var option = document.createElement("option");
select.appendChild(option);
var options = select.options;
var observeSelect = internals.observeGC(select);
var observeOption = internals.observeGC(option);
var observeOptions = internals.observeGC(options);
select = null;
option = null;
gc();
shouldBeTrue('observeSelect.wasCollected');
shouldBeTrue('observeOption.wasCollected');
shouldBeFalse('observeOptions.wasCollected');
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment