Commit 5080de38 authored by W. James MacLean's avatar W. James MacLean Committed by Commit Bot

Tentatively re-enable ScrollBubblingFromOOPIFWithBodyOverflowHidden.

It's possible that the change landed in
https://chromium-review.googlesource.com/c/chromium/src/+/1172723
will resolve the flakiness seen in this test. If not, it would be
nice to get some fresh logs from the bots for debugging purposes.

Bug: 863971
Change-Id: I332b48990e0503e078ccc657d3537c3a6d4f9c7a
Reviewed-on: https://chromium-review.googlesource.com/1210042Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589179}
parent 63d85e79
...@@ -1836,19 +1836,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, ...@@ -1836,19 +1836,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
scroll_observer->Wait(); scroll_observer->Wait();
} }
#if defined(OS_CHROMEOS) || defined(OS_MACOSX)
// Flaky: https://crbug.com/836200.
// Flaky timeouts on Mac: https://crbug.com/863971.
#define MAYBE_ScrollBubblingFromOOPIFWithBodyOverflowHidden \
DISABLED_ScrollBubblingFromOOPIFWithBodyOverflowHidden
#else
#define MAYBE_ScrollBubblingFromOOPIFWithBodyOverflowHidden \
ScrollBubblingFromOOPIFWithBodyOverflowHidden
#endif
// Tests that scrolling bubbles from an oopif if its source body has // Tests that scrolling bubbles from an oopif if its source body has
// "overflow:hidden" style. // "overflow:hidden" style.
IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
MAYBE_ScrollBubblingFromOOPIFWithBodyOverflowHidden) { ScrollBubblingFromOOPIFWithBodyOverflowHidden) {
GURL url_domain_a(embedded_test_server()->GetURL( GURL url_domain_a(embedded_test_server()->GetURL(
"a.com", "/scrollable_page_with_iframe.html")); "a.com", "/scrollable_page_with_iframe.html"));
EXPECT_TRUE(NavigateToURL(shell(), url_domain_a)); EXPECT_TRUE(NavigateToURL(shell(), url_domain_a));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment