Record casting source metrics even if MediaRouterViewsUI is destroyed

When the Cast dialog is closed, MediaRouterViewsUI gets destroyed. If
that happened before casting succeeded, we weren't recording the cast
source. This CL fixes that.

Change-Id: I58fb7d9db16867bce1728788b8c21694b33d3dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904821Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715779}

chrome/browser/ui/views/media_router/media_router_views_ui.cc

@@ -85,6 +85,12 @@ MediaSource GetSourceForRouteObserver(const std::vector<MediaSource>& sources) {
   return source_it != sources.end() ? *source_it : MediaSource(std::string());
 }
 
+void MaybeReportCastingSource(MediaCastMode cast_mode,
+                              const RouteRequestResult& result) {
+  if (result.result_code() == RouteRequestResult::OK)
+    MediaRouterMetrics::RecordMediaRouterCastingSource(cast_mode);
+}
+
 }  // namespace
 
 // Observes a WebContents and requests fullscreening of its first
@@ -342,13 +348,6 @@ void MediaRouterViewsUI::TerminateRoute(const MediaRoute::Id& route_id) {
   GetMediaRouter()->TerminateRoute(route_id);
 }
 
-void MediaRouterViewsUI::MaybeReportCastingSource(
-    MediaCastMode cast_mode,
-    const RouteRequestResult& result) {
-  if (result.result_code() == RouteRequestResult::OK)
-    MediaRouterMetrics::RecordMediaRouterCastingSource(cast_mode);
-}
-
 std::vector<MediaSinkWithCastModes> MediaRouterViewsUI::GetEnabledSinks()
     const {
   if (!display_observer_)
@@ -626,8 +625,7 @@ base::Optional<RouteParameters> MediaRouterViewsUI::GetRouteParameters(
   // HandleCreateSessionRequestRouteResponse(), which closes the dialog and
   // destroys |this|.
   params.route_result_callbacks.push_back(
-      base::BindOnce(&MediaRouterViewsUI::MaybeReportCastingSource,
-                     weak_factory_.GetWeakPtr(), cast_mode));
+      base::BindOnce(&MaybeReportCastingSource, cast_mode));
 
   // There are 3 cases. In cases (1) and (3) the MediaRouterViewsUI will need to
   // be notified via OnRouteResponseReceived(). In case (2) the dialog will be
@@ -901,8 +899,7 @@ base::Optional<RouteParameters> MediaRouterViewsUI::GetLocalFileRouteParameters(
       GetPresentationRequestSourceName()));
 
   params.route_result_callbacks.push_back(
-      base::BindOnce(&MediaRouterViewsUI::MaybeReportCastingSource,
-                     weak_factory_.GetWeakPtr(), MediaCastMode::LOCAL_FILE));
+      base::BindOnce(&MaybeReportCastingSource, MediaCastMode::LOCAL_FILE));
 
   params.route_result_callbacks.push_back(
       base::BindOnce(&MediaRouterViewsUI::MaybeReportFileInformation,

chrome/browser/ui/views/media_router/media_router_views_ui.h

@@ -114,10 +114,6 @@ class MediaRouterViewsUI
   // Calls MediaRouter to terminate the given route.
   void TerminateRoute(const MediaRoute::Id& route_id);
 
-  // Logs a UMA stat for the source that was cast if the result is successful.
-  void MaybeReportCastingSource(MediaCastMode cast_mode,
-                                const RouteRequestResult& result);
-
   // Returns a subset of |sinks_| that should be listed in the dialog. This
   // excludes the wired display that the initiator WebContents is on.
   // Also filters cloud sinks in incognito windows.