Commit 50b79dc6 authored by aurimas's avatar aurimas Committed by Commit bot

Unify expand and collapse icons.

- Switch to using expand and collapse icons from internal repo
- Start using TintedDrawable for WebsitePreferences.

BUG=454859

Review URL: https://codereview.chromium.org/900743003

Cr-Commit-Position: refs/heads/master@{#314686}
parent 91bc7932
...@@ -64,8 +64,8 @@ public class ExpandablePreferenceGroup extends PreferenceGroup { ...@@ -64,8 +64,8 @@ public class ExpandablePreferenceGroup extends PreferenceGroup {
} }
@Override @Override
public void setIcon(int resourceId) { public void setIcon(Drawable drawable) {
mDrawable = getContext().getResources().getDrawable(resourceId); mDrawable = drawable;
if (mImageView != null) mImageView.setImageDrawable(mDrawable); if (mImageView != null) mImageView.setImageDrawable(mDrawable);
} }
......
...@@ -31,6 +31,7 @@ import org.chromium.chrome.browser.preferences.LocationSettings; ...@@ -31,6 +31,7 @@ import org.chromium.chrome.browser.preferences.LocationSettings;
import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate; import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate;
import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils; import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils;
import org.chromium.chrome.browser.preferences.PrefServiceBridge; import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.widget.TintedDrawable;
import org.chromium.ui.text.SpanApplier; import org.chromium.ui.text.SpanApplier;
import org.chromium.ui.text.SpanApplier.SpanInfo; import org.chromium.ui.text.SpanApplier.SpanInfo;
...@@ -437,8 +438,9 @@ public class WebsitePreferences extends PreferenceFragment ...@@ -437,8 +438,9 @@ public class WebsitePreferences extends PreferenceFragment
// Set the title and arrow icons for the header. // Set the title and arrow icons for the header.
allowedGroup.setGroupTitle(resourceId, numAllowed); allowedGroup.setGroupTitle(resourceId, numAllowed);
allowedGroup.setIcon( TintedDrawable icon = TintedDrawable.constructTintedDrawable(getResources(),
mAllowListExpanded ? R.drawable.ic_expand_less : R.drawable.ic_expand_more); mAllowListExpanded ? R.drawable.ic_expand : R.drawable.ic_collapse);
allowedGroup.setIcon(icon);
} }
private void updateBlockedHeader(int numBlocked) { private void updateBlockedHeader(int numBlocked) {
...@@ -452,19 +454,22 @@ public class WebsitePreferences extends PreferenceFragment ...@@ -452,19 +454,22 @@ public class WebsitePreferences extends PreferenceFragment
// Set the title and arrow icons for the header. // Set the title and arrow icons for the header.
blockedGroup.setGroupTitle(R.string.website_settings_blocked_group_heading, numBlocked); blockedGroup.setGroupTitle(R.string.website_settings_blocked_group_heading, numBlocked);
blockedGroup.setIcon( TintedDrawable icon = TintedDrawable.constructTintedDrawable(getResources(),
mBlockListExpanded ? R.drawable.ic_expand_less : R.drawable.ic_expand_more); mBlockListExpanded ? R.drawable.ic_expand : R.drawable.ic_collapse);
blockedGroup.setIcon(icon);
} }
private Website createSiteByOrigin(WebsiteAddress address) { private Website createSiteByOrigin(WebsiteAddress address) {
String origin = address.getOrigin(); String origin = address.getOrigin();
String host = address.getHost(); String host = address.getHost();
Website site = new Website(address); Website site = new Website(address);
if (!mSitesByOrigin.containsKey(origin)) if (!mSitesByOrigin.containsKey(origin)) {
mSitesByOrigin.put(origin, new HashSet<Website>()); mSitesByOrigin.put(origin, new HashSet<Website>());
}
mSitesByOrigin.get(origin).add(site); mSitesByOrigin.get(origin).add(site);
if (!mSitesByHost.containsKey(host)) if (!mSitesByHost.containsKey(host)) {
mSitesByHost.put(host, new HashSet<Website>()); mSitesByHost.put(host, new HashSet<Website>());
}
mSitesByHost.get(host).add(site); mSitesByHost.get(host).add(site);
return site; return site;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment