Settings import data dialog: send only checked checkboxes

During import process from C++ part we send
supported import options (checkboxes). In js
part we hide not supported checkboxes. But then
we send from js to C++ user choised checkboxes
includes hidden (that is true by default).
Need to exclude hidden checkboxes as unchecked.

Bug: 1107356
Change-Id: Idf372718c632217a5474e12b4117213f12c027e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310532Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791311}

chrome/browser/resources/settings/people_page/import_data_dialog.js

@@ -150,7 +150,7 @@ Polymer({
     } else {
       const types = {};
       checkboxes.forEach(checkbox => {
-        types[checkbox.pref.key] = checkbox.checked;
+        types[checkbox.pref.key] = checkbox.checked && !checkbox.hidden;
       });
       this.browserProxy_.importData(this.$.browserSelect.selectedIndex, types);
     }

chrome/test/data/webui/settings/import_data_dialog_test.js

@@ -59,7 +59,7 @@ suite('ImportDataDialog', function() {
     {
       autofillFormData: true,
       favorites: true,
-      history: true,
+      history: false,  // Emulate unsupported import option
       index: 1,
       name: 'Mozilla Firefox',
       passwords: true,
@@ -233,6 +233,27 @@ suite('ImportDataDialog', function() {
     });
   });
 
+  test('ImportFromBrowserProfileWithUnsupportedOption', function() {
+    // Flip all prefs to true.
+    Object.keys(prefs).forEach(function(prefName) {
+      ensureSettingsCheckboxCheckedStatus(prefName, true);
+    });
+
+    const expectedIndex = 1;
+    simulateBrowserProfileChange(expectedIndex);
+    dialog.$.import.click();
+
+    const importCalled = browserProxy.whenCalled('importData');
+    return importCalled.then(([actualIndex, types]) => {
+      assertEquals(expectedIndex, actualIndex);
+
+      Object.keys(prefs).forEach(function(prefName) {
+        // import_dialog_history is unsupported and hidden
+        assertEquals(prefName !== 'import_dialog_history', types[prefName]);
+      });
+    });
+  });
+
   test('ImportError', function() {
     simulateImportStatusChange(ImportDataStatus.FAILED);
     assertFalse(dialog.$.dialog.open);