Commit 50dcc591 authored by yurys@chromium.org's avatar yurys@chromium.org

Remove HeapSnapshot._markInvisibleEdges

The method is a noop as we first collect names of shortcut edges and then iterate through all non-shortcuts whose names are also in the collection.

BUG=None

Review URL: https://codereview.chromium.org/204913005

git-svn-id: svn://svn.chromium.org/blink/trunk@169657 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent b7ca2d2b
...@@ -951,8 +951,6 @@ WebInspector.HeapSnapshot.prototype = { ...@@ -951,8 +951,6 @@ WebInspector.HeapSnapshot.prototype = {
this._progress.updateStatus("Building edge indexes\u2026"); this._progress.updateStatus("Building edge indexes\u2026");
this._buildEdgeIndexes(); this._buildEdgeIndexes();
this._progress.updateStatus("Marking invisible edges\u2026");
this._markInvisibleEdges();
this._progress.updateStatus("Building retainers\u2026"); this._progress.updateStatus("Building retainers\u2026");
this._buildRetainers(); this._buildRetainers();
this._progress.updateStatus("Calculating node flags\u2026"); this._progress.updateStatus("Calculating node flags\u2026");
...@@ -1737,11 +1735,6 @@ WebInspector.HeapSnapshot.prototype = { ...@@ -1737,11 +1735,6 @@ WebInspector.HeapSnapshot.prototype = {
} }
}, },
_markInvisibleEdges: function()
{
throw new Error("Not implemented");
},
_calculateFlags: function() _calculateFlags: function()
{ {
throw new Error("Not implemented"); throw new Error("Not implemented");
......
...@@ -125,33 +125,6 @@ WebInspector.JSHeapSnapshot.prototype = { ...@@ -125,33 +125,6 @@ WebInspector.JSHeapSnapshot.prototype = {
delete this._flags; delete this._flags;
}, },
_markInvisibleEdges: function()
{
// Mark hidden edges of global objects as invisible.
// FIXME: This is a temporary measure. Normally, we should
// really hide all hidden nodes.
for (var iter = this.rootNode().edges(); iter.hasNext(); iter.next()) {
var edge = iter.edge;
if (!edge.isShortcut())
continue;
var node = edge.node();
var propNames = {};
for (var innerIter = node.edges(); innerIter.hasNext(); innerIter.next()) {
var globalObjEdge = innerIter.edge;
if (globalObjEdge.isShortcut())
propNames[globalObjEdge._nameOrIndex()] = true;
}
for (var innerIter = node.edges(); innerIter.hasNext(); innerIter.next()) {
var globalObjEdge = innerIter.edge;
if (!globalObjEdge.isShortcut()
&& globalObjEdge.node().isHidden()
&& globalObjEdge._hasStringName()
&& (globalObjEdge._nameOrIndex() in propNames))
globalObjEdge._edges[globalObjEdge.edgeIndex + this._edgeTypeOffset] = this._edgeInvisibleType;
}
}
},
_calculateFlags: function() _calculateFlags: function()
{ {
this._flags = new Uint32Array(this.nodeCount); this._flags = new Uint32Array(this.nodeCount);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment