Commit 5108e861 authored by Lukasz Anforowicz's avatar Lukasz Anforowicz Committed by Commit Bot

Adjust ServerRedirectSingleProcess expectations for site-per-process.

WebNavigationApiTest.ServerRedirectSingleProcess from browser_tests has
its expectations in
serverRedirectSingleProcess/test_serverRedirectSingleProcess.js.  The
expectations include exact |processId| ("exact" meaning that one cannot
use a wildcard - the verification is done via chrome.test.checkDeepEq).
Inclusion of |processId| means that the expectation change in
site-per-process mode.

This CL flips the expectations to match the expected behavior in
site-per-process mode and disables the test outside of site-per-process
mode.  The "disabling" can be removed in a follow-up CL, after we only
run //chrome-layer tests in site-per-process mode.

Bug: 671734
Change-Id: I984d67342008c3025b84406d99d4798ca46d77f6
Reviewed-on: https://chromium-review.googlesource.com/1162909Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581003}
parent e94c4ae4
...@@ -246,9 +246,18 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Download) { ...@@ -246,9 +246,18 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Download) {
} }
IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, ServerRedirectSingleProcess) { IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, ServerRedirectSingleProcess) {
// TODO(lukasza): https://crbug.com/671734: Investigate why this test fails // TODO(lukasza): https://crbug.com/671734: In the long-term, //chrome-layer
// with --site-per-process. // tests should only be run with site-per-process - remove the early return
if (content::AreAllSitesIsolatedForTesting()) // below when fixing https://crbug.com/870761 and removing the
// not_site_per_process_browser_tests step.
//
// This test has its expectations in
// serverRedirectSingleProcess/test_serverRedirectSingleProcess.js. The
// expectations include exact |processId| ("exact" meaning that one cannot use
// a wildcard - the verification is done via chrome.test.checkDeepEq).
// Inclusion of |processId| means that the expectation change in
// site-per-process mode.
if (!content::AreAllSitesIsolatedForTesting())
return; return;
ASSERT_TRUE(StartEmbeddedTestServer()); ASSERT_TRUE(StartEmbeddedTestServer());
......
...@@ -69,7 +69,7 @@ onload = function() { ...@@ -69,7 +69,7 @@ onload = function() {
{ label: "b-onCommitted", { label: "b-onCommitted",
event: "onCommitted", event: "onCommitted",
details: { frameId: 0, details: { frameId: 0,
processId: 0, processId: 1,
tabId: 0, tabId: 0,
timeStamp: 0, timeStamp: 0,
transitionQualifiers: ["server_redirect"], transitionQualifiers: ["server_redirect"],
...@@ -78,14 +78,14 @@ onload = function() { ...@@ -78,14 +78,14 @@ onload = function() {
{ label: "b-onDOMContentLoaded", { label: "b-onDOMContentLoaded",
event: "onDOMContentLoaded", event: "onDOMContentLoaded",
details: { frameId: 0, details: { frameId: 0,
processId: 0, processId: 1,
tabId: 0, tabId: 0,
timeStamp: 0, timeStamp: 0,
url: URL_TARGET }}, url: URL_TARGET }},
{ label: "b-onCompleted", { label: "b-onCompleted",
event: "onCompleted", event: "onCompleted",
details: { frameId: 0, details: { frameId: 0,
processId: 0, processId: 1,
tabId: 0, tabId: 0,
timeStamp: 0, timeStamp: 0,
url: URL_TARGET }}], url: URL_TARGET }}],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment