Commit 51124613 authored by Shakti Sahu's avatar Shakti Sahu Committed by Chromium LUCI CQ

Read Later : Added field trial testing config

This CL adds field trial testing config for read later feature.

TBR=dtrainor@chromium.org

Bug: 1158565
Change-Id: I8c30b6cb39d9081f00aae6683a108d1d889f4414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591227Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837555}
parent 8ec0ae2c
......@@ -266,6 +266,7 @@ public class BookmarkTest {
@Test
@SmallTest
@Features.DisableFeatures({ChromeFeatureList.READ_LATER})
public void testAddBookmark() throws Exception {
mActivityTestRule.loadUrl(mTestPage);
// Check partner bookmarks are lazily loaded.
......@@ -298,6 +299,7 @@ public class BookmarkTest {
@Test
@SmallTest
@Features.DisableFeatures({ChromeFeatureList.READ_LATER})
public void testAddBookmarkSnackbar() {
mActivityTestRule.loadUrl(mTestPage);
// Check partner bookmarks are lazily loaded.
......@@ -331,6 +333,7 @@ public class BookmarkTest {
@Test
@SmallTest
@Features.DisableFeatures({ChromeFeatureList.READ_LATER})
public void testAddBookmarkToOtherFolder() {
mActivityTestRule.loadUrl(mTestPage);
readPartnerBookmarks();
......@@ -1319,6 +1322,7 @@ public class BookmarkTest {
@Test
@MediumTest
@Features.DisableFeatures({ChromeFeatureList.READ_LATER})
public void testTopLevelFolderUpdateAfterSync() throws Exception {
// Set up the test and open the bookmark manager to the Mobile Bookmarks folder.
readPartnerBookmarks();
......
......@@ -600,9 +600,10 @@ public class RevampedContextMenuTest implements DownloadTestRule.CustomMainActiv
R.id.contextmenu_open_in_incognito_tab, R.id.contextmenu_save_link_as,
R.id.contextmenu_copy_link_text, R.id.contextmenu_copy_link_address,
R.id.contextmenu_share_link};
Integer[] featureItems = {R.id.contextmenu_open_in_ephemeral_tab};
expectedItems =
addItemsIf(EphemeralTabCoordinator.isSupported(), expectedItems, featureItems);
expectedItems = addItemsIf(EphemeralTabCoordinator.isSupported(), expectedItems,
new Integer[] {R.id.contextmenu_open_in_ephemeral_tab});
expectedItems = addItemsIf(ChromeFeatureList.isEnabled(ChromeFeatureList.READ_LATER),
expectedItems, new Integer[] {R.id.contextmenu_read_later});
assertMenuItemsAreEqual(menu, expectedItems);
}
......
......@@ -6038,6 +6038,86 @@
]
}
],
"ReadLater": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"ReadLater"
]
}
]
}
],
"ReadLaterAppMenuBookmarkThisPage": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "ReadLaterAppMenuBookmarkThisPage",
"params": {
"availability": ">=0",
"event_1": "name:read_later_bottom_sheet_folder_seen;comparator:==0;window:30;storage:30",
"event_trigger": "name:read_later_app_menu_bookmark_this_page_iph_trigger;comparator:==0;window:30;storage:30",
"event_used": "name:app_menu_bookmark_star_icon_pressed;comparator:==0;window:30;storage:30",
"session_rate": "<1"
},
"enable_features": [
"IPH_ReadLaterAppMenuBookmarkThisPage"
]
}
]
}
],
"ReadLaterAppMenuBookmarks": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "ReadLaterAppMenuBookmarks",
"params": {
"availability": ">=0",
"event_1": "name:read_later_article_saved;comparator:>=1;window:30;storage:30",
"event_trigger": "name:read_later_app_menu_bookmarks_iph_trigger;comparator:==0;window:30;storage:30",
"event_used": "name:read_later_bookmark_folder_opened;comparator:==0;window:30;storage:30",
"session_rate": "<1"
},
"enable_features": [
"IPH_ReadLaterAppMenuBookmarks"
]
}
]
}
],
"ReadLaterContextMenu": [
{
"platforms": [
"android"
],
"experiments": [
{
"name": "ReadLaterContextMenu",
"params": {
"availability": ">=0",
"event_trigger": "name:read_later_context_menu_tapped_iph_trigger;comparator:==0;window:30;storage:30",
"event_used": "name:read_later_context_menu_tapped;comparator:==0;window:30;storage:30",
"session_rate": "<1"
},
"enable_features": [
"IPH_ReadLaterContextMenu"
]
}
]
}
],
"ReleaseNotesNotification": [
{
"platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment