Chrome style plugin: apply fixits in //third_party/blink/renderer/bindings

Bug: 706466
Change-Id: I6f9db18aaca1c24a3da055907786943e55ea36d9
Reviewed-on: https://chromium-review.googlesource.com/1027115Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553447}

third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc

@@ -85,7 +85,7 @@ class ActivityLoggerTest : public testing::Test {
                                 "about:blank");
   }
 
-  ~ActivityLoggerTest() { WebCache::Clear(); }
+  ~ActivityLoggerTest() override { WebCache::Clear(); }
 
   void ExecuteScriptInMainWorld(const String& script) const {
     v8::HandleScope scope(v8::Isolate::GetCurrent());

third_party/blink/renderer/bindings/core/v8/custom/v8_custom_xpath_ns_resolver.h

@@ -49,7 +49,7 @@ class V8CustomXPathNSResolver final : public XPathNSResolver {
 
   AtomicString lookupNamespaceURI(const String& prefix) override;
 
-  virtual void Trace(blink::Visitor*);
+  void Trace(blink::Visitor*) override;
 
  private:
   V8CustomXPathNSResolver(ScriptState*, v8::Local<v8::Object> resolver);

third_party/blink/renderer/bindings/core/v8/initialize_v8_extras_binding.cc

@@ -59,7 +59,7 @@ class CountUseForBindings : public ScriptFunction {
       return ScriptValue();
     }
 
-    const auto it =
+    auto* const it =
         std::find_if(std::begin(web_feature_id_name_lookup_table),
                      std::end(web_feature_id_name_lookup_table),
                      [&string_id](const WebFeatureIdNameLookupEntry& entry) {

third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h

@@ -41,9 +41,9 @@ class CORE_EXPORT ScriptCustomElementDefinition final
       HashSet<AtomicString>&& observed_attributes,
       CSSStyleSheet*);
 
-  virtual ~ScriptCustomElementDefinition() = default;
+  ~ScriptCustomElementDefinition() override = default;
 
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
 
   v8::Local<v8::Object> Constructor() const;
 

third_party/blink/renderer/bindings/core/v8/script_module_test.cc

@@ -23,7 +23,7 @@ namespace {
 class TestScriptModuleResolver final : public ScriptModuleResolver {
  public:
   TestScriptModuleResolver() = default;
-  virtual ~TestScriptModuleResolver() = default;
+  ~TestScriptModuleResolver() override = default;
 
   size_t ResolveCount() const { return specifiers_.size(); }
   const Vector<String>& Specifiers() const { return specifiers_; }
@@ -55,9 +55,9 @@ class TestScriptModuleResolver final : public ScriptModuleResolver {
 class ScriptModuleTestModulator final : public DummyModulator {
  public:
   ScriptModuleTestModulator();
-  virtual ~ScriptModuleTestModulator() = default;
+  ~ScriptModuleTestModulator() override = default;
 
-  void Trace(blink::Visitor*);
+  void Trace(blink::Visitor*) override;
 
   TestScriptModuleResolver* GetTestScriptModuleResolver() {
     return resolver_.Get();
@@ -168,8 +168,8 @@ TEST(ScriptModuleTest, moduleRequests) {
 TEST(ScriptModuleTest, instantiateNoDeps) {
   V8TestingScope scope;
 
-  auto modulator = new ScriptModuleTestModulator();
-  auto resolver = modulator->GetTestScriptModuleResolver();
+  auto* modulator = new ScriptModuleTestModulator();
+  auto* resolver = modulator->GetTestScriptModuleResolver();
 
   Modulator::SetModulator(scope.GetScriptState(), modulator);
 
@@ -188,8 +188,8 @@ TEST(ScriptModuleTest, instantiateNoDeps) {
 TEST(ScriptModuleTest, instantiateWithDeps) {
   V8TestingScope scope;
 
-  auto modulator = new ScriptModuleTestModulator();
-  auto resolver = modulator->GetTestScriptModuleResolver();
+  auto* modulator = new ScriptModuleTestModulator();
+  auto* resolver = modulator->GetTestScriptModuleResolver();
 
   Modulator::SetModulator(scope.GetScriptState(), modulator);
 
@@ -226,8 +226,8 @@ TEST(ScriptModuleTest, instantiateWithDeps) {
 TEST(ScriptModuleTest, EvaluationErrrorIsRemembered) {
   V8TestingScope scope;
 
-  auto modulator = new ScriptModuleTestModulator();
-  auto resolver = modulator->GetTestScriptModuleResolver();
+  auto* modulator = new ScriptModuleTestModulator();
+  auto* resolver = modulator->GetTestScriptModuleResolver();
 
   Modulator::SetModulator(scope.GetScriptState(), modulator);
 
@@ -263,7 +263,7 @@ TEST(ScriptModuleTest, EvaluationErrrorIsRemembered) {
 TEST(ScriptModuleTest, Evaluate) {
   V8TestingScope scope;
 
-  auto modulator = new ScriptModuleTestModulator();
+  auto* modulator = new ScriptModuleTestModulator();
   Modulator::SetModulator(scope.GetScriptState(), modulator);
 
   const KURL js_url("https://example.com/foo.js");
@@ -296,7 +296,7 @@ TEST(ScriptModuleTest, Evaluate) {
 TEST(ScriptModuleTest, EvaluateCaptureError) {
   V8TestingScope scope;
 
-  auto modulator = new ScriptModuleTestModulator();
+  auto* modulator = new ScriptModuleTestModulator();
   Modulator::SetModulator(scope.GetScriptState(), modulator);
 
   const KURL js_url("https://example.com/foo.js");

third_party/blink/renderer/bindings/core/v8/script_promise.cc

@@ -73,7 +73,7 @@ class PromiseAllHandler final
       return self->BindToV8Function();
     }
 
-    virtual void Trace(blink::Visitor* visitor) {
+    void Trace(blink::Visitor* visitor) override {
       visitor->Trace(handler_);
       ScriptFunction::Trace(visitor);
     }

third_party/blink/renderer/bindings/core/v8/script_promise_property_base.h

@@ -48,7 +48,7 @@ class CORE_EXPORT ScriptPromisePropertyBase
 
   ScriptPromise Promise(DOMWrapperWorld&);
 
-  virtual void Trace(blink::Visitor*);
+  void Trace(blink::Visitor*) override;
 
  protected:
   ScriptPromisePropertyBase(ExecutionContext*, Name);

third_party/blink/renderer/bindings/core/v8/script_promise_property_test.cc

@@ -88,7 +88,7 @@ class GarbageCollectedHolder : public GarbageCollectedScriptWrappable {
     return this;
   }
 
-  virtual void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     GarbageCollectedScriptWrappable::Trace(visitor);
     visitor->Trace(property_);
   }

third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h

@@ -101,7 +101,7 @@ class CORE_EXPORT ScriptPromiseResolver
   // promise is pending and the associated ExecutionContext isn't stopped.
   void KeepAliveWhilePending();
 
-  virtual void Trace(blink::Visitor*);
+  void Trace(blink::Visitor*) override;
 
  protected:
   // You need to call suspendIfNeeded after the construction because

third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc

@@ -62,7 +62,7 @@ class ScriptStreamingTest : public testing::Test {
     GetResource()->SetResponse(response);
   }
 
-  ~ScriptStreamingTest() {
+  ~ScriptStreamingTest() override {
     if (pending_script_)
       pending_script_->Dispose();
   }

third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc

@@ -150,7 +150,7 @@ TEST(ScriptWrappableMarkingVisitorTest, OilpanClearsHeadersWhenObjectDied) {
       V8PerIsolateData::From(scope.GetIsolate())
           ->GetScriptWrappableMarkingVisitor();
   visitor->TracePrologue();
-  auto header = HeapObjectHeader::FromPayload(object);
+  auto* header = HeapObjectHeader::FromPayload(object);
   visitor->HeadersToUnmark()->push_back(header);
 
   PreciselyCollectGarbage();
@@ -248,7 +248,7 @@ class HandleContainer
   virtual ~HandleContainer() = default;
 
   void Trace(blink::Visitor* visitor) {}
-  void TraceWrappers(const ScriptWrappableVisitor* visitor) const {
+  void TraceWrappers(const ScriptWrappableVisitor* visitor) const override {
     visitor->TraceWrappers(handle_.Cast<v8::Value>());
   }
   const char* NameInHeapSnapshot() const override { return "HandleContainer"; }
@@ -269,7 +269,9 @@ class InterceptingScriptWrappableMarkingVisitor
   InterceptingScriptWrappableMarkingVisitor(v8::Isolate* isolate)
       : ScriptWrappableMarkingVisitor(isolate),
         marked_wrappers_(new size_t(0)) {}
-  ~InterceptingScriptWrappableMarkingVisitor() { delete marked_wrappers_; }
+  ~InterceptingScriptWrappableMarkingVisitor() override {
+    delete marked_wrappers_;
+  }
 
   void Visit(const TraceWrapperV8Reference<v8::Value>&) const override {
     *marked_wrappers_ += 1;

third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc

@@ -378,7 +378,7 @@ void SerializedScriptValue::CloneSharedArrayBuffers(
   HeapHashSet<Member<DOMArrayBufferBase>> visited;
   shared_array_buffers_contents_.Grow(array_buffers.size());
   size_t i = 0;
-  for (auto it = array_buffers.begin(); it != array_buffers.end(); ++it) {
+  for (auto* it = array_buffers.begin(); it != array_buffers.end(); ++it) {
     DOMSharedArrayBuffer* shared_array_buffer = *it;
     if (visited.Contains(shared_array_buffer))
       continue;
@@ -510,7 +510,7 @@ ArrayBufferArray SerializedScriptValue::ExtractNonSharedArrayBuffers(
   ArrayBufferArray result;
   // Partition array_buffers into [shared..., non_shared...], maintaining
   // relative ordering of elements with the same predicate value.
-  auto non_shared_begin =
+  auto* non_shared_begin =
       std::stable_partition(array_buffers.begin(), array_buffers.end(),
                             [](Member<DOMArrayBufferBase>& array_buffer) {
                               return array_buffer->IsShared();
@@ -533,7 +533,7 @@ SerializedScriptValue::TransferArrayBufferContents(
   if (!array_buffers.size())
     return ArrayBufferContentsArray();
 
-  for (auto it = array_buffers.begin(); it != array_buffers.end(); ++it) {
+  for (auto* it = array_buffers.begin(); it != array_buffers.end(); ++it) {
     DOMArrayBufferBase* array_buffer = *it;
     if (array_buffer->IsNeutered()) {
       size_t index = std::distance(array_buffers.begin(), it);
@@ -546,7 +546,7 @@ SerializedScriptValue::TransferArrayBufferContents(
 
   contents.Grow(array_buffers.size());
   HeapHashSet<Member<DOMArrayBufferBase>> visited;
-  for (auto it = array_buffers.begin(); it != array_buffers.end(); ++it) {
+  for (auto* it = array_buffers.begin(); it != array_buffers.end(); ++it) {
     DOMArrayBufferBase* array_buffer_base = *it;
     if (visited.Contains(array_buffer_base))
       continue;

third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.h

@@ -111,8 +111,8 @@ class CORE_EXPORT V8AbstractEventListener : public EventListener {
   v8::Isolate* GetIsolate() const { return isolate_; }
   DOMWrapperWorld& World() const { return *world_; }
 
-  virtual void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void Trace(blink::Visitor*) override;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
 
  protected:
   V8AbstractEventListener(v8::Isolate*, bool is_attribute, DOMWrapperWorld&);

third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc

@@ -173,7 +173,7 @@ V8EmbedderGraphBuilder::EmbedderNode* V8EmbedderGraphBuilder::GraphNode(
   }
   // Ownership of the new node is transferred to the graph_.
   // graph_node_.at(tracable) is valid for all BuildEmbedderGraph execution.
-  auto raw_node = new EmbedderNode(name, wrapper, dom_tree_state);
+  auto* raw_node = new EmbedderNode(name, wrapper, dom_tree_state);
   EmbedderNode* node = static_cast<EmbedderNode*>(
       graph_->AddNode(std::unique_ptr<Graph::Node>(raw_node)));
   graph_node_.insert(traceable, node);

third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.h

@@ -89,7 +89,7 @@ class V8EmbedderGraphBuilder : public ScriptWrappableVisitor,
     explicit EmbedderRootNode(const char* name)
         : EmbedderNode(name, nullptr, DomTreeState::kUnknown) {}
     // Graph::Node override.
-    bool IsRootNode() { return true; }
+    bool IsRootNode() override { return true; }
   };
 
   class ParentScope {

third_party/blink/renderer/bindings/core/v8/v8_intersection_observer_delegate.h

@@ -29,8 +29,8 @@ class V8IntersectionObserverDelegate final
 
   ExecutionContext* GetExecutionContext() const override;
 
-  virtual void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void Trace(blink::Visitor*) override;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
 
   void Deliver(const HeapVector<Member<IntersectionObserverEntry>>&,
                IntersectionObserver&) override;

third_party/blink/renderer/bindings/core/v8/v8_lazy_event_listener.h

@@ -57,12 +57,12 @@ class V8LazyEventListener final : public V8AbstractEventListener {
                                    code, source_url, position, node);
   }
 
-  virtual void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     visitor->Trace(node_);
     V8AbstractEventListener::Trace(visitor);
   }
 
-  const String& Code() const { return code_; }
+  const String& Code() const override { return code_; }
 
  protected:
   v8::Local<v8::Object> GetListenerObjectInternal(ExecutionContext*) override;

third_party/blink/renderer/bindings/core/v8/v8_v0_custom_element_lifecycle_callbacks.h

@@ -60,7 +60,7 @@ class V8V0CustomElementLifecycleCallbacks final
 
   bool SetBinding(std::unique_ptr<V0CustomElementBinding>);
 
-  virtual void Trace(blink::Visitor*);
+  void Trace(blink::Visitor*) override;
 
  private:
   V8V0CustomElementLifecycleCallbacks(

third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc

@@ -84,7 +84,7 @@ class FetchDataLoaderAsWasmModule final : public FetchDataLoader,
     return AbortCompilation();
   }
 
-  void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     visitor->Trace(consumer_);
     visitor->Trace(client_);
     FetchDataLoader::Trace(visitor);