Fix DCHECK in TestBackgroundPageFirstLoadObserver

Fix the problem with the DCHECK in
TestBackgroundPageFirstLoadObserver::OnBackgroundHostCreated() being hit
in case when the extension's background page host gets destroyed and
recreated.

The DCHECK was fired because the class didn't expect to observe more
than one host at the same time. The underlying issue was that the class
didn't stop observing the deleted host, leading to the DCHECK hit and a
potential use-after-free (in tests).

Bug: 1090941
Test: stress-test the "CertificateProviderApiTest.LazyBackgroundPage" browser test after applying crrev.com/c/2312817
Change-Id: I91cf8f3bb0126a04b63e3a73d3f39259c621f330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312799Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791054}

extensions/test/test_background_page_first_load_observer.cc

@@ -37,6 +37,14 @@ void TestBackgroundPageFirstLoadObserver::OnBackgroundHostCreated(
   }
 }
 
+void TestBackgroundPageFirstLoadObserver::OnExtensionHostDestroyed(
+    ExtensionHost* host) {
+  if (host->extension_id() == extension_id_) {
+    extension_host_observer_.Remove(host);
+    extension_host_ = nullptr;
+  }
+}
+
 void TestBackgroundPageFirstLoadObserver::OnExtensionHostDidStopFirstLoad(
     const ExtensionHost* host) {
   run_loop_.Quit();

extensions/test/test_background_page_first_load_observer.h

@@ -18,10 +18,10 @@ namespace content {
 class BrowserContext;
 }
 
-// Allows to wait until the WebContents of an extension's ExtensionHost sees its
-// first DidStopLoading().
 namespace extensions {
 
+// Allows to wait until the WebContents of an extension's ExtensionHost sees its
+// first DidStopLoading().
 class TestBackgroundPageFirstLoadObserver : public ProcessManagerObserver,
                                             public ExtensionHostObserver {
  public:
@@ -36,6 +36,7 @@ class TestBackgroundPageFirstLoadObserver : public ProcessManagerObserver,
   void OnBackgroundHostCreated(ExtensionHost* host) override;
 
   // ExtensionHostObserver:
+  void OnExtensionHostDestroyed(ExtensionHost* host) override;
   void OnExtensionHostDidStopFirstLoad(const ExtensionHost* host) override;
 
   void OnObtainedExtensionHost();