Commit 517d32ba authored by Alan Cutter's avatar Alan Cutter Committed by Commit Bot

Fix warning for ValueStoreTest

This CL fixes the warning in app_shell_unittests:
The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ValueStoreTest>

value_store_unittest.cc defines a TestWithParam class without
instantiating it. Targets that include this via test_support that don't
instantiate the test for themselves (dozens) will trigger the warning.

Bug: 1045846
Change-Id: If6a87e19af1783a8f58ec3e0ff1f03d933c0251e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143776
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759538}
parent fa8e7a2a
......@@ -4839,6 +4839,7 @@ test("unit_tests") {
"//components/services/unzip:in_process",
"//extensions:extensions_resources",
"//extensions/browser:test_support",
"//extensions/browser:value_store_test_support",
"//extensions/common",
"//extensions/renderer:unit_test_support",
"//extensions/strings",
......
......@@ -549,8 +549,6 @@ jumbo_source_set("test_support") {
"value_store/test_value_store_factory.h",
"value_store/testing_value_store.cc",
"value_store/testing_value_store.h",
"value_store/value_store_unittest.cc",
"value_store/value_store_unittest.h",
]
deps = [
......@@ -572,6 +570,22 @@ jumbo_source_set("test_support") {
[ "//extensions/browser/api/declarative_net_request:test_support" ]
}
jumbo_source_set("value_store_test_support") {
testonly = true
sources = [
"value_store/value_store_unittest.cc",
"value_store/value_store_unittest.h",
]
deps = [
"//base",
"//base/test:test_support",
"//content/test:test_support",
"//extensions/browser",
"//testing/gtest",
]
}
source_set("unit_tests") {
testonly = true
sources = [
......@@ -673,6 +687,7 @@ source_set("unit_tests") {
deps = [
":browser",
":test_support",
":value_store_test_support",
"//base",
"//base/test:test_support",
"//components/cast_certificate",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment