Notify ExtensionApps when ArcAppListPrefs is destroyed.

When ArcAppListPrefs is destroyed, ExtensionApps doesn't clear the
arc_prefs_. So ExtensionApps still calls arc_prefs_ to remove itself from the
observer list, which could cause the memory issue, when ArcAppListPrefs is
deleted first. Update ArcAppListPrefs to notify the observer,
ExtensionApps, when ArcAppListPrefs is destroyed.
Note: ExtensionApps doesn't depend on ArcAppListPrefs, becuase even if no ARC
on the Chrome OS, ExtensionApps still exists.

BUG=1013850

Change-Id: I389e7b7c2d4e11a5af7f927a1595f75d7b2cc1f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857840
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705558}

chrome/browser/apps/app_service/extension_apps.cc

@@ -597,6 +597,10 @@ void ExtensionApps::OnPackageListInitialRefreshed() {
   }
 }
 
+void ExtensionApps::OnArcAppListPrefsDestroyed() {
+  arc_prefs_ = nullptr;
+}
+
 // static
 bool ExtensionApps::IsBlacklisted(const std::string& app_id) {
   // We blacklist (meaning we don't publish the app, in the App Service sense)

chrome/browser/apps/app_service/extension_apps.h

@@ -119,6 +119,7 @@ class ExtensionApps : public apps::mojom::Publisher,
   void OnPackageRemoved(const std::string& package_name,
                         bool uninstalled) override;
   void OnPackageListInitialRefreshed() override;
+  void OnArcAppListPrefsDestroyed() override;
 
   void Publish(apps::mojom::AppPtr app);
 

chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

@@ -410,6 +410,9 @@ ArcAppListPrefs::ArcAppListPrefs(
 }
 
 ArcAppListPrefs::~ArcAppListPrefs() {
+  for (auto& observer : observer_list_)
+    observer.OnArcAppListPrefsDestroyed();
+
   arc::ArcSessionManager* arc_session_manager = arc::ArcSessionManager::Get();
   if (!arc_session_manager)
     return;

chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

@@ -217,6 +217,9 @@ class ArcAppListPrefs : public KeyedService,
     virtual void OnInstallationFinished(const std::string& package_name,
                                         bool success) {}
 
+    // Notifies that ArcAppListPrefs is destroyed.
+    virtual void OnArcAppListPrefsDestroyed() {}
+
    protected:
     virtual ~Observer() {}
   };