SkipToGPay close client if details invalid
Context: Organize the logic of parseAndValidateDetailsOrDisconnectFromClient to prepare for splitting it into business logic and UI logic. The change of this CL is done based on the discussion[1]. Change: * Rename setShippingOption into setShippingOptionIfValid so as to be explicit about the validation purpose. * Close client before SkipToGPay error out. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1787117/5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java#1243 Change-Id: I918fb133444d32797b7a71d3aede4586c3c0cb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372802 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801026}
Showing
Please register or sign in to comment