Commit 51c6d817 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in...

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=hbos@chromium.org

Bug: 925652
Change-Id: I445f4f95d8a656e531fe96b8dfa42fef9ea7728d
Reviewed-on: https://chromium-review.googlesource.com/c/1438290
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: default avatarHenrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626503}
parent edf03f29
......@@ -113,6 +113,6 @@ IN_PROC_BROWSER_TEST_P(WebRtcWebcamBrowserTest,
GetUserMediaAndGetStreamSize(tab, kVideoCallConstraints1080p));
}
INSTANTIATE_TEST_CASE_P(WebRtcWebcamBrowserTests,
WebRtcWebcamBrowserTest,
testing::ValuesIn(kTargetVideoCaptureImplementations));
INSTANTIATE_TEST_SUITE_P(WebRtcWebcamBrowserTests,
WebRtcWebcamBrowserTest,
testing::ValuesIn(kTargetVideoCaptureImplementations));
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment